2015-11-09 15:13:37

by Ranjith Thangavel

Subject: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith <[email protected]>
---
drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
index 15a4093..1bf8ddc 100644
--- a/drivers/staging/comedi/drivers/comedi_parport.c
+++ b/drivers/staging/comedi/drivers/comedi_parport.c
@@ -75,8 +75,8 @@
#define PARPORT_DATA_REG 0x00
#define PARPORT_STATUS_REG 0x01
#define PARPORT_CTRL_REG 0x02
-#define PARPORT_CTRL_IRQ_ENA (1 << 4)
-#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
+#define PARPORT_CTRL_IRQ_ENA BIT(4)
+#define PARPORT_CTRL_BIDIR_ENA BIT(5)

static int parport_data_reg_insn_bits(struct comedi_device *dev,
struct comedi_subdevice *s,
--
1.7.10.4

2015-11-09 16:55:46

by Hartley Sweeten

Subject: RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith <[email protected]>
> ---
> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
> #define PARPORT_DATA_REG 0x00
> #define PARPORT_STATUS_REG 0x01
> #define PARPORT_CTRL_REG 0x02
> -#define PARPORT_CTRL_IRQ_ENA (1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA BIT(5)
>
> static int parport_data_reg_insn_bits(struct comedi_device *dev,
> struct comedi_subdevice *s,

Hello,

No problems with the patch but your sign-off needs to include your
full legal name.

Regards,
Hartley