Clang warns:
In file included from sound/soc/intel/keembay/kmb_platform.c:14:
sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
is used as a header guard here, followed by #define of a different
macro [-Wheader-guard]
#ifndef KMB_PLATFORM_H_
^~~~~~~~~~~~~~~
sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
is defined here; did you mean 'KMB_PLATFORM_H_'?
#define KMB_PLATFORMP_H_
^~~~~~~~~~~~~~~~
KMB_PLATFORM_H_
1 warning generated.
Fix the typo so that the header guard works as intended.
Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1053
Signed-off-by: Nathan Chancellor <[email protected]>
---
sound/soc/intel/keembay/kmb_platform.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h
index 29600652d8f4..6bf221aa8fff 100644
--- a/sound/soc/intel/keembay/kmb_platform.h
+++ b/sound/soc/intel/keembay/kmb_platform.h
@@ -7,7 +7,7 @@
*/
#ifndef KMB_PLATFORM_H_
-#define KMB_PLATFORMP_H_
+#define KMB_PLATFORM_H_
#include <linux/bits.h>
#include <linux/bitfield.h>
base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313
--
2.27.0
Looks good to me.
Thanks
Regards
Jee Heng
-----Original Message-----
From: Nathan Chancellor <[email protected]>
Sent: Wednesday, June 17, 2020 9:03 AM
To: Rojewski, Cezary <[email protected]>; Pierre-Louis Bossart <[email protected]>; Liam Girdwood <[email protected]>; Jie Yang <[email protected]>; Mark Brown <[email protected]>
Cc: Sia, Jee Heng <[email protected]>; [email protected]; [email protected]; [email protected]; Nathan Chancellor <[email protected]>
Subject: [PATCH] ASoC: Intel: KeemBay: Fix header guard
Clang warns:
In file included from sound/soc/intel/keembay/kmb_platform.c:14:
sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef KMB_PLATFORM_H_
^~~~~~~~~~~~~~~
sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
is defined here; did you mean 'KMB_PLATFORM_H_'?
#define KMB_PLATFORMP_H_
^~~~~~~~~~~~~~~~
KMB_PLATFORM_H_
1 warning generated.
Fix the typo so that the header guard works as intended.
Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1053
Signed-off-by: Nathan Chancellor <[email protected]>
---
sound/soc/intel/keembay/kmb_platform.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h
index 29600652d8f4..6bf221aa8fff 100644
--- a/sound/soc/intel/keembay/kmb_platform.h
+++ b/sound/soc/intel/keembay/kmb_platform.h
@@ -7,7 +7,7 @@
*/
#ifndef KMB_PLATFORM_H_
-#define KMB_PLATFORMP_H_
+#define KMB_PLATFORM_H_
#include <linux/bits.h>
#include <linux/bitfield.h>
base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313
--
2.27.0
On Tue, Jun 16, 2020 at 06:02:32PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from sound/soc/intel/keembay/kmb_platform.c:14:
> sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
> is used as a header guard here, followed by #define of a different
> macro [-Wheader-guard]
> #ifndef KMB_PLATFORM_H_
> ^~~~~~~~~~~~~~~
> sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
> is defined here; did you mean 'KMB_PLATFORM_H_'?
> #define KMB_PLATFORMP_H_
> ^~~~~~~~~~~~~~~~
> KMB_PLATFORM_H_
> 1 warning generated.
>
> Fix the typo so that the header guard works as intended.
>
> Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1053
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
> sound/soc/intel/keembay/kmb_platform.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h
> index 29600652d8f4..6bf221aa8fff 100644
> --- a/sound/soc/intel/keembay/kmb_platform.h
> +++ b/sound/soc/intel/keembay/kmb_platform.h
> @@ -7,7 +7,7 @@
> */
>
> #ifndef KMB_PLATFORM_H_
> -#define KMB_PLATFORMP_H_
> +#define KMB_PLATFORM_H_
>
> #include <linux/bits.h>
> #include <linux/bitfield.h>
>
> base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313
> --
> 2.27.0
>
Ping? This is a rather trivial patch.
Cheers,
Nathan
On Tue, Jun 30, 2020 at 02:04:41PM -0700, Nathan Chancellor wrote:
> Ping? This is a rather trivial patch.
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
On Tue, Jun 16, 2020 at 6:02 PM Nathan Chancellor
<[email protected]> wrote:
>
> Clang warns:
>
> In file included from sound/soc/intel/keembay/kmb_platform.c:14:
> sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
> is used as a header guard here, followed by #define of a different
> macro [-Wheader-guard]
> #ifndef KMB_PLATFORM_H_
> ^~~~~~~~~~~~~~~
> sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
> is defined here; did you mean 'KMB_PLATFORM_H_'?
> #define KMB_PLATFORMP_H_
> ^~~~~~~~~~~~~~~~
> KMB_PLATFORM_H_
> 1 warning generated.
>
> Fix the typo so that the header guard works as intended.
>
> Fixes: c5477e966728 ("ASoC: Intel: Add KeemBay platform driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1053
> Signed-off-by: Nathan Chancellor <[email protected]>
Reviewed-by: Nick Desaulniers <[email protected]>
> ---
> sound/soc/intel/keembay/kmb_platform.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/keembay/kmb_platform.h b/sound/soc/intel/keembay/kmb_platform.h
> index 29600652d8f4..6bf221aa8fff 100644
> --- a/sound/soc/intel/keembay/kmb_platform.h
> +++ b/sound/soc/intel/keembay/kmb_platform.h
> @@ -7,7 +7,7 @@
> */
>
> #ifndef KMB_PLATFORM_H_
> -#define KMB_PLATFORMP_H_
> +#define KMB_PLATFORM_H_
>
> #include <linux/bits.h>
> #include <linux/bitfield.h>
>
> base-commit: 27f70ec4fa0e0f419031f1b8d61b1a788244e313
> --
> 2.27.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200617010232.23222-1-natechancellor%40gmail.com.
--
Thanks,
~Nick Desaulniers
On Tue, 16 Jun 2020 18:02:32 -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from sound/soc/intel/keembay/kmb_platform.c:14:
> sound/soc/intel/keembay/kmb_platform.h:9:9: warning: 'KMB_PLATFORM_H_'
> is used as a header guard here, followed by #define of a different
> macro [-Wheader-guard]
> #ifndef KMB_PLATFORM_H_
> ^~~~~~~~~~~~~~~
> sound/soc/intel/keembay/kmb_platform.h:10:9: note: 'KMB_PLATFORMP_H_'
> is defined here; did you mean 'KMB_PLATFORM_H_'?
> #define KMB_PLATFORMP_H_
> ^~~~~~~~~~~~~~~~
> KMB_PLATFORM_H_
> 1 warning generated.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: Intel: KeemBay: Fix header guard
commit: 9a7794bd4a28e274f9f247f1ea230f2f0f1077a2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark