This series of patches is to simplify UFS driver initialization flow
and add a new parameter max_lu_supported used to specify how many LUs
supported by the UFS device.
v1-v2:
1. Split ufshcd_probe_hba() based on its called flow
2. Delete two unnecessary functions
3. Add a fixup patch
Bean Huo (9):
scsi: ufs: goto with returned value while failed to add WL
scsi: ufs: Delete struct ufs_dev_desc
scsi: ufs: Split ufshcd_probe_hba() based on its called flow
scsi: ufs: Move ufshcd_get_max_pwr_mode() to ufs_init_params()
scsi: ufs: Delete two unnecessary functions
scsi: ufs: Delete is_init_prefetch from struct ufs_hba
scsi: ufs: Add max_lu_supported in struct ufs_dev_info
scsi: ufs: Initialize max_lu_supported
scsi: ufs: Use UFS device indicated maximum LU number
drivers/scsi/ufs/ufs-mediatek.c | 7 +-
drivers/scsi/ufs/ufs-qcom.c | 6 +-
drivers/scsi/ufs/ufs-sysfs.c | 2 +-
drivers/scsi/ufs/ufs.h | 25 ++-
drivers/scsi/ufs/ufs_quirks.h | 9 +-
drivers/scsi/ufs/ufshcd.c | 276 +++++++++++++++++++-------------
drivers/scsi/ufs/ufshcd.h | 9 +-
7 files changed, 196 insertions(+), 138 deletions(-)
--
2.17.1
From: Bean Huo <[email protected]>
This patch is to make goto statement with failure result in case of
failure of adding well known LUs.
Fixes: 2a8fa600445c ("ufs: manually add well known logical units")
Signed-off-by: Bean Huo <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index bea036ab189a..9a9085a7bcc5 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7032,7 +7032,8 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
ufshcd_init_icc_levels(hba);
/* Add required well known logical units to scsi mid layer */
- if (ufshcd_scsi_add_wlus(hba))
+ ret = ufshcd_scsi_add_wlus(hba);
+ if (ret)
goto out;
/* Initialize devfreq after UFS device is detected */
--
2.17.1
On 2020-01-16 13:59, Bean Huo wrote:
> From: Bean Huo <[email protected]>
>
> This patch is to make goto statement with failure result in case of
> failure of adding well known LUs.
Please make the subject more clear, e.g. "Fix ufshcd_probe_hba() return
value in case ufshcd_scsi_add_wlus() fails"
Thanks,
Bart.
Hi, Bart
> On 2020-01-16 13:59, Bean Huo wrote:
> > From: Bean Huo <[email protected]>
> >
> > This patch is to make goto statement with failure result in case of
> > failure of adding well known LUs.
>
> Please make the subject more clear, e.g. "Fix ufshcd_probe_hba() return value in
> case ufshcd_scsi_add_wlus() fails"
>
Ok, you are always expert on English, I will change it in next version.
Thanks,
//Bean
On 1/16/2020 1:59 PM, Bean Huo wrote:
> From: Bean Huo <[email protected]>
>
> This patch is to make goto statement with failure result in case of
> failure of adding well known LUs.
>
> Fixes: 2a8fa600445c ("ufs: manually add well known logical units")
> Signed-off-by: Bean Huo <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index bea036ab189a..9a9085a7bcc5 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7032,7 +7032,8 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
> ufshcd_init_icc_levels(hba);
>
> /* Add required well known logical units to scsi mid layer */
> - if (ufshcd_scsi_add_wlus(hba))
> + ret = ufshcd_scsi_add_wlus(hba);
> + if (ret)
> goto out;
>
> /* Initialize devfreq after UFS device is detected */
>
Please retain my reviewed-by tag, if you change the commit message as
per Bart's reviews in your next version.
Reviewed-by: Asutosh Das <[email protected]>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project