2019-11-12 00:25:07

by Bean Huo (beanhuo)

Subject: [RESEND PATCH v1 1/2] scsi: ufs: print helpful hint when response size exceed buffer size

Bean Huo <[email protected]>

Reset since ver.kernel.org rejected outlook.com.
Print out returned response size and buffer size, while the front one
is bigger than the back one.

Signed-off-by: Bean Huo <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 11a87f51c442..fdb4f5b7f4bd 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1935,8 +1935,8 @@ int ufshcd_copy_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
memcpy(hba->dev_cmd.query.descriptor, descp, resp_len);
} else {
dev_warn(hba->dev,
- "%s: Response size is bigger than buffer",
- __func__);
+ "%s: rsp size %d is bigger than buffer size %d",
+ __func__, resp_len, buf_len);
return -EINVAL;
}
}
@@ -5856,7 +5856,9 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
memcpy(desc_buff, descp, resp_len);
*buff_len = resp_len;
} else {
- dev_warn(hba->dev, "rsp size is bigger than buffer");
+ dev_warn(hba->dev,
+ "%s: rsp size %d is bigger than buffer size %d",
+ __func__, resp_len, *buff_len);
*buff_len = 0;
err = -EINVAL;
}
--
2.7.4

2019-11-12 16:42:04

by Bart Van Assche

Subject: Re: [RESEND PATCH v1 1/2] scsi: ufs: print helpful hint when response size exceed buffer size

On 11/11/19 4:21 PM, Bean Huo (beanhuo) wrote:
>
> Bean Huo <[email protected]>
>
> Reset since ver.kernel.org rejected outlook.com.
> Print out returned response size and buffer size, while the front one
> is bigger than the back one.
>
> Signed-off-by: Bean Huo <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 11a87f51c442..fdb4f5b7f4bd 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1935,8 +1935,8 @@ int ufshcd_copy_query_response(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> memcpy(hba->dev_cmd.query.descriptor, descp, resp_len);
> } else {
> dev_warn(hba->dev,
> - "%s: Response size is bigger than buffer",
> - __func__);
> + "%s: rsp size %d is bigger than buffer size %d",
> + __func__, resp_len, buf_len);
> return -EINVAL;
> }
> }
> @@ -5856,7 +5856,9 @@ static int ufshcd_issue_devman_upiu_cmd(struct ufs_hba *hba,
> memcpy(desc_buff, descp, resp_len);
> *buff_len = resp_len;
> } else {
> - dev_warn(hba->dev, "rsp size is bigger than buffer");
> + dev_warn(hba->dev,
> + "%s: rsp size %d is bigger than buffer size %d",
> + __func__, resp_len, *buff_len);
> *buff_len = 0;
> err = -EINVAL;
> }

Hi Bean,

Please use git format-patch and/or git send-email to publish patches
such that the standard format is used ("From: " is missing from the
first line). Anyway:

Reviewed-by: Bart Van Assche <[email protected]>