2020-11-16 03:19:03

by Jianpeng Ma

Subject: bitmap: Remove unused function declaration

Signed-off-by: Jianpeng Ma <[email protected]>
---
include/linux/bitmap.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 99058eb81042..6f08965c69a5 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
* lib/bitmap.c provides these functions:
*/

-extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
-extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
extern int __bitmap_equal(const unsigned long *bitmap1,
const unsigned long *bitmap2, unsigned int nbits);
extern bool __pure __bitmap_or_equal(const unsigned long *src1,
--
2.28.0

2020-11-16 04:36:23

by Yury Norov

Subject: Re: bitmap: Remove unused function declaration

(CC related people)

Since there is no actual implementation for them, there's , I think
it's safe (and better)
to remove the declarations. Thanks for the catch.

Acked-by: Yury Norov <[email protected]>

On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <[email protected]> wrote:
>
> Signed-off-by: Jianpeng Ma <[email protected]>
> ---
> include/linux/bitmap.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 99058eb81042..6f08965c69a5 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> * lib/bitmap.c provides these functions:
> */
>
> -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> extern int __bitmap_equal(const unsigned long *bitmap1,
> const unsigned long *bitmap2, unsigned int nbits);
> extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> --
> 2.28.0

2020-11-17 01:45:12

by Andy Shevchenko

Subject: Re: bitmap: Remove unused function declaration

On Sun, Nov 15, 2020 at 07:59:37PM -0800, Yury Norov wrote:
> (CC related people)
>
> Since there is no actual implementation for them, there's , I think
> it's safe (and better)
> to remove the declarations. Thanks for the catch.

Fixes: 2afe27c718b6 ("lib/bitmap.c: bitmap_[empty,full]: remove code duplication")

Reviewed-by: Andy Shevchenko <[email protected]>

> Acked-by: Yury Norov <[email protected]>
>
> On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <[email protected]> wrote:
> >
> > Signed-off-by: Jianpeng Ma <[email protected]>
> > ---
> > include/linux/bitmap.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> > index 99058eb81042..6f08965c69a5 100644
> > --- a/include/linux/bitmap.h
> > +++ b/include/linux/bitmap.h
> > @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> > * lib/bitmap.c provides these functions:
> > */
> >
> > -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> > -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> > extern int __bitmap_equal(const unsigned long *bitmap1,
> > const unsigned long *bitmap2, unsigned int nbits);
> > extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> > --
> > 2.28.0

--
With Best Regards,
Andy Shevchenko