tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head: 51ea3f9e9017b47c15b37a200d8e81e36a169b70
commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220902/[email protected]/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
git remote add char-misc https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
git fetch --no-tags char-misc char-misc-testing
git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/misc/mchp_pci1xxxx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
All error/warnings (new ones prefixed by >>):
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function 'gp_aux_bus_probe':
>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error: 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
87 | retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
| ^~~~~~~~~~~~~~~~~
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: note: each undeclared identifier is reported only once for each function it appears in
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: At top level:
>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:162:1: warning: data definition has no type or storage class
162 | module_pci_driver(pci1xxxx_gp_driver);
| ^~~~~~~~~~~~~~~~~
>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:162:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:162:1: warning: parameter names (without types) in function declaration
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:155:26: warning: 'pci1xxxx_gp_driver' defined but not used [-Wunused-variable]
155 | static struct pci_driver pci1xxxx_gp_driver = {
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/PCI_IRQ_ALL_TYPES +87 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
31
32 static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id)
33 {
34 struct aux_bus_device *aux_bus;
35 int retval;
36
37 retval = pcim_enable_device(pdev);
38 if (retval)
39 return retval;
40
41 aux_bus = kzalloc(sizeof(*aux_bus), GFP_KERNEL);
42 if (!aux_bus)
43 return -ENOMEM;
44
45 aux_bus->aux_device_wrapper[0] = kzalloc(sizeof(*aux_bus->aux_device_wrapper[0]),
46 GFP_KERNEL);
47 if (!aux_bus->aux_device_wrapper[0])
48 return -ENOMEM;
49
50 retval = ida_alloc(&gp_client_ida, GFP_KERNEL);
51 if (retval < 0)
52 goto err_ida_alloc_0;
53
54 aux_bus->aux_device_wrapper[0]->aux_dev.name = aux_dev_otp_e2p_name;
55 aux_bus->aux_device_wrapper[0]->aux_dev.dev.parent = &pdev->dev;
56 aux_bus->aux_device_wrapper[0]->aux_dev.dev.release = gp_auxiliary_device_release;
57 aux_bus->aux_device_wrapper[0]->aux_dev.id = retval;
58
59 aux_bus->aux_device_wrapper[0]->gp_aux_data.region_start = pci_resource_start(pdev, 0);
60 aux_bus->aux_device_wrapper[0]->gp_aux_data.region_length = pci_resource_end(pdev, 0);
61
62 retval = auxiliary_device_init(&aux_bus->aux_device_wrapper[0]->aux_dev);
63 if (retval < 0)
64 goto err_aux_dev_init_0;
65
66 retval = auxiliary_device_add(&aux_bus->aux_device_wrapper[0]->aux_dev);
67 if (retval)
68 goto err_aux_dev_add_0;
69
70 aux_bus->aux_device_wrapper[1] = kzalloc(sizeof(*aux_bus->aux_device_wrapper[1]),
71 GFP_KERNEL);
72 if (!aux_bus->aux_device_wrapper[1])
73 return -ENOMEM;
74
75 retval = ida_alloc(&gp_client_ida, GFP_KERNEL);
76 if (retval < 0)
77 goto err_ida_alloc_1;
78
79 aux_bus->aux_device_wrapper[1]->aux_dev.name = aux_dev_gpio_name;
80 aux_bus->aux_device_wrapper[1]->aux_dev.dev.parent = &pdev->dev;
81 aux_bus->aux_device_wrapper[1]->aux_dev.dev.release = gp_auxiliary_device_release;
82 aux_bus->aux_device_wrapper[1]->aux_dev.id = retval;
83
84 aux_bus->aux_device_wrapper[1]->gp_aux_data.region_start = pci_resource_start(pdev, 0);
85 aux_bus->aux_device_wrapper[1]->gp_aux_data.region_length = pci_resource_end(pdev, 0);
86
> 87 retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
88
89 if (retval < 0)
90 return retval;
91
92 pdev->irq = pci_irq_vector(pdev, 0);
93 if (pdev->irq < 0)
94 return retval;
95
96 aux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num = pdev->irq;
97
98 retval = auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev);
99 if (retval < 0)
100 goto err_aux_dev_init_1;
101
102 retval = auxiliary_device_add(&aux_bus->aux_device_wrapper[1]->aux_dev);
103 if (retval)
104 goto err_aux_dev_add_1;
105
106 pci_set_drvdata(pdev, aux_bus);
107 pci_set_master(pdev);
108
109 return 0;
110
111 err_aux_dev_add_1:
112 auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);
113
114 err_aux_dev_init_1:
115 ida_free(&gp_client_ida, aux_bus->aux_device_wrapper[1]->aux_dev.id);
116
117 err_ida_alloc_1:
118 kfree(aux_bus->aux_device_wrapper[1]);
119
120 err_aux_dev_add_0:
121 auxiliary_device_uninit(&aux_bus->aux_device_wrapper[0]->aux_dev);
122
123 err_aux_dev_init_0:
124 ida_free(&gp_client_ida, aux_bus->aux_device_wrapper[0]->aux_dev.id);
125
126 err_ida_alloc_0:
127 kfree(aux_bus->aux_device_wrapper[0]);
128
129 return retval;
130 }
131
132 static void gp_aux_bus_remove(struct pci_dev *pdev)
133 {
134 struct aux_bus_device *aux_bus = pci_get_drvdata(pdev);
135
136 auxiliary_device_delete(&aux_bus->aux_device_wrapper[0]->aux_dev);
137 auxiliary_device_uninit(&aux_bus->aux_device_wrapper[0]->aux_dev);
138 auxiliary_device_delete(&aux_bus->aux_device_wrapper[1]->aux_dev);
139 auxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);
140 kfree(aux_bus);
141 pci_disable_device(pdev);
142 }
143
144 static const struct pci_device_id pci1xxxx_tbl[] = {
145 { PCI_DEVICE(0x1055, 0xA005) },
146 { PCI_DEVICE(0x1055, 0xA015) },
147 { PCI_DEVICE(0x1055, 0xA025) },
148 { PCI_DEVICE(0x1055, 0xA035) },
149 { PCI_DEVICE(0x1055, 0xA045) },
150 { PCI_DEVICE(0x1055, 0xA055) },
151 {0,}
152 };
153 MODULE_DEVICE_TABLE(pci, pci1xxxx_tbl);
154
155 static struct pci_driver pci1xxxx_gp_driver = {
156 .name = "PCI1xxxxGP",
157 .id_table = pci1xxxx_tbl,
158 .probe = gp_aux_bus_probe,
159 .remove = gp_aux_bus_remove,
160 };
161
> 162 module_pci_driver(pci1xxxx_gp_driver);
163
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
> head: 51ea3f9e9017b47c15b37a200d8e81e36a169b70
> commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220902/[email protected]/config)
> compiler: sh4-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> git remote add char-misc https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> git fetch --no-tags char-misc char-misc-testing
> git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/misc/mchp_pci1xxxx/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <[email protected]>
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function 'gp_aux_bus_probe':
> >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error: 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> 87 | retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> | ^~~~~~~~~~~~~~~~~
Odd.
Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
Kumaravel, can you send an add-on patch for this issue with the proper
"Reported-by:" line as asked for above?
thanks,
greg k-h
> -----Original Message-----
> From: Greg Kroah-Hartman <[email protected]>
> Sent: Friday, September 2, 2022 12:33 PM
> To: kernel test robot <[email protected]>; Kumaravel Thiagarajan - I21417
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: Re: [char-misc:char-misc-testing 20/24]
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> 'PCI_IRQ_ALL_TYPES' undeclared
>
>
> On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> misc.git char-misc-testing
> > head: 51ea3f9e9017b47c15b37a200d8e81e36a169b70
> > commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc:
> microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-
> function endpoint of pci1xxxx device.
> > config: sh-allmodconfig
> > (https://download.01.org/0day-
> ci/archive/20220902/202209020641.mPiacQE
> > [email protected]/config)
> > compiler: sh4-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-
> tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > git remote add char-misc
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > git fetch --no-tags char-misc char-misc-testing
> > git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> > make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
> > drivers/misc/mchp_pci1xxxx/
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <[email protected]>
> >
> > All error/warnings (new ones prefixed by >>):
> >
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function
> 'gp_aux_bus_probe':
> > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > >> 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> > 87 | retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > | ^~~~~~~~~~~~~~~~~
>
> Odd.
>
> Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
>
> Kumaravel, can you send an add-on patch for this issue with the proper
> "Reported-by:" line as asked for above?
Greg, for the add-on patch, can I modify only the KConfig file which you can apply to
commit id: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d of char-misc-testing?
Thank You.
Regards,
Kumar
On Fri, Sep 02, 2022 at 08:30:22AM +0000, [email protected] wrote:
>
>
> > -----Original Message-----
> > From: Greg Kroah-Hartman <[email protected]>
> > Sent: Friday, September 2, 2022 12:33 PM
> > To: kernel test robot <[email protected]>; Kumaravel Thiagarajan - I21417
> > <[email protected]>; [email protected]; linux-
> > [email protected]
> > Subject: Re: [char-misc:char-misc-testing 20/24]
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > 'PCI_IRQ_ALL_TYPES' undeclared
> >
> >
> > On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > misc.git char-misc-testing
> > > head: 51ea3f9e9017b47c15b37a200d8e81e36a169b70
> > > commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc:
> > microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-
> > function endpoint of pci1xxxx device.
> > > config: sh-allmodconfig
> > > (https://download.01.org/0day-
> > ci/archive/20220902/202209020641.mPiacQE
> > > [email protected]/config)
> > > compiler: sh4-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-
> > tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > git remote add char-misc
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > git fetch --no-tags char-misc char-misc-testing
> > > git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> > > make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
> > > drivers/misc/mchp_pci1xxxx/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All error/warnings (new ones prefixed by >>):
> > >
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function
> > 'gp_aux_bus_probe':
> > > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > >> 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> > > 87 | retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > > | ^~~~~~~~~~~~~~~~~
> >
> > Odd.
> >
> > Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
> >
> > Kumaravel, can you send an add-on patch for this issue with the proper
> > "Reported-by:" line as asked for above?
> Greg, for the add-on patch, can I modify only the KConfig file which you can apply to
> commit id: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d of char-misc-testing?
Yes, I can merge them together.
thanks,
greg k-h
> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Friday, September 2, 2022 2:22 PM
> To: Kumaravel Thiagarajan - I21417 <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]
> Subject: Re: [char-misc:char-misc-testing 20/24]
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> 'PCI_IRQ_ALL_TYPES' undeclared
>
> On Fri, Sep 02, 2022 at 08:30:22AM +0000,
> [email protected] wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <[email protected]>
> > > Sent: Friday, September 2, 2022 12:33 PM
> > > To: kernel test robot <[email protected]>; Kumaravel Thiagarajan -
> > > I21417 <[email protected]>;
> > > [email protected]; linux- [email protected]
> > > Subject: Re: [char-misc:char-misc-testing 20/24]
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > 'PCI_IRQ_ALL_TYPES' undeclared
> > >
> > >
> > > On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > > misc.git char-misc-testing
> > > > head: 51ea3f9e9017b47c15b37a200d8e81e36a169b70
> > > > commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc:
> > > microchip: pci1xxxx: load auxiliary bus driver for the PIO function
> > > in the multi- function endpoint of pci1xxxx device.
> > > > config: sh-allmodconfig
> > > > (https://download.01.org/0day-
> > > ci/archive/20220902/202209020641.mPiacQE
> > > > [email protected]/config)
> > > > compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1
> > > > build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-
> > > tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > #
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > > misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > > git remote add char-misc
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > > git fetch --no-tags char-misc char-misc-testing
> > > > git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> > > > make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
> > > > drivers/misc/mchp_pci1xxxx/
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <[email protected]>
> > > >
> > > > All error/warnings (new ones prefixed by >>):
> > > >
> > > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function
> > > 'gp_aux_bus_probe':
> > > > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > > >> 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> > > > 87 | retval = pci_alloc_irq_vectors(pdev, 1, 1,
> PCI_IRQ_ALL_TYPES);
> > > > | ^~~~~~~~~~~~~~~~~
> > >
> > > Odd.
> > >
> > > Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
> > >
> > > Kumaravel, can you send an add-on patch for this issue with the
> > > proper "Reported-by:" line as asked for above?
> > Greg, for the add-on patch, can I modify only the KConfig file which
> > you can apply to commit id: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d of
> char-misc-testing?
>
> Yes, I can merge them together.
Greg, I have sent the patch. Please apply and let me know.
Thank You.
Regards,
Kumaravel