2021-10-14 01:30:39

by Jiasheng Jiang

Subject: [PATCH] hv_netvsc: Add comment of netvsc_xdp_xmit()

Adding comment to avoid the misusing of netvsc_xdp_xmit().
Otherwise the value of skb->queue_mapping could be 0 and
then the return value of skb_get_rx_queue() could be MAX_U16
cause by overflow.

Fixes: 351e158 ("hv_netvsc: Add XDP support")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/net/hyperv/netvsc_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index f682a55..ac9529c 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -803,6 +803,7 @@ void netvsc_linkstatus_callback(struct net_device *net,
schedule_delayed_work(&ndev_ctx->dwork, 0);
}

+/* This function should only be called after skb_record_rx_queue() */
static void netvsc_xdp_xmit(struct sk_buff *skb, struct net_device *ndev)
{
int rc;
--
2.7.4

2021-10-14 14:28:18

by Haiyang Zhang

Subject: RE: [PATCH] hv_netvsc: Add comment of netvsc_xdp_xmit()

> -----Original Message-----
> From: Jiasheng Jiang <[email protected]>
> Sent: Wednesday, October 13, 2021 9:26 PM
> To: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Stephen Hemminger <[email protected]>;
> [email protected]; Dexuan Cui <[email protected]>;
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Jiasheng Jiang
> <[email protected]>
> Subject: [PATCH] hv_netvsc: Add comment of netvsc_xdp_xmit()
>
> Adding comment to avoid the misusing of netvsc_xdp_xmit().
> Otherwise the value of skb->queue_mapping could be 0 and
> then the return value of skb_get_rx_queue() could be MAX_U16
> cause by overflow.
>
> Fixes: 351e158 ("hv_netvsc: Add XDP support")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/net/hyperv/netvsc_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/hyperv/netvsc_drv.c
> b/drivers/net/hyperv/netvsc_drv.c
> index f682a55..ac9529c 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -803,6 +803,7 @@ void netvsc_linkstatus_callback(struct net_device
> *net,
> schedule_delayed_work(&ndev_ctx->dwork, 0);
> }
>
> +/* This function should only be called after skb_record_rx_queue() */
> static void netvsc_xdp_xmit(struct sk_buff *skb, struct net_device
> *ndev)
> {

Thanks.

Reviewed-by: Haiyang Zhang <[email protected]>

2021-10-15 10:56:55

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] hv_netvsc: Add comment of netvsc_xdp_xmit()

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 14 Oct 2021 01:26:26 +0000 you wrote:
> Adding comment to avoid the misusing of netvsc_xdp_xmit().
> Otherwise the value of skb->queue_mapping could be 0 and
> then the return value of skb_get_rx_queue() could be MAX_U16
> cause by overflow.
>
> Fixes: 351e158 ("hv_netvsc: Add XDP support")
> Signed-off-by: Jiasheng Jiang <[email protected]>
>
> [...]

Here is the summary with links:
- hv_netvsc: Add comment of netvsc_xdp_xmit()
https://git.kernel.org/netdev/net-next/c/78e0a006914b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html