2024-04-03 21:36:04

by Jacob Pan

Subject: [PATCH] iommu/vt-d: Allocate local memory for page request queue

The page request queue is per IOMMU, its allocation should be made
NUMA-aware for performance reasons.

Signed-off-by: Jacob Pan <[email protected]>
---
drivers/iommu/intel/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index c1bed89b1026..ee3b469e2da1 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -66,7 +66,7 @@ int intel_svm_enable_prq(struct intel_iommu *iommu)
struct page *pages;
int irq, ret;

- pages = alloc_pages(GFP_KERNEL | __GFP_ZERO, PRQ_ORDER);
+ pages = alloc_pages_node(iommu->node, GFP_KERNEL | __GFP_ZERO, PRQ_ORDER);
if (!pages) {
pr_warn("IOMMU: %s: Failed to allocate page request queue\n",
iommu->name);
--
2.25.1

2024-04-08 07:36:30

by Tian, Kevin

Subject: RE: [PATCH] iommu/vt-d: Allocate local memory for page request queue

> From: Jacob Pan <[email protected]>
> Sent: Thursday, April 4, 2024 5:40 AM
>
> The page request queue is per IOMMU, its allocation should be made
> NUMA-aware for performance reasons.
>
> Signed-off-by: Jacob Pan <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>

2024-04-11 02:50:45

by Baolu Lu

Subject: Re: [PATCH] iommu/vt-d: Allocate local memory for page request queue

On 4/8/24 3:36 PM, Tian, Kevin wrote:
>> From: Jacob Pan<[email protected]>
>> Sent: Thursday, April 4, 2024 5:40 AM
>>
>> The page request queue is per IOMMU, its allocation should be made
>> NUMA-aware for performance reasons.
>>
>> Signed-off-by: Jacob Pan<[email protected]>
> Reviewed-by: Kevin Tian<[email protected]>

Add below fix tag and queue it for v6.9-rc.

Fixes: a222a7f0bb6c ("iommu/vt-d: Implement page request handling")

Best regards,
baolu