2024-02-27 06:49:51

by zhangfei

Subject: [PATCH rc] iommu/sva: Fix SVA handle sharing in multi device case

iommu_sva_bind_device will directly goto out in multi-device
case when found existing domain, ignoring list_add handle,
which causes the handle to fail to be shared.

Fixes: 65d4418c5002 ("iommu/sva: Restore SVA handle sharing")
Signed-off-by: Zhangfei Gao <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
---
Based on rc6

drivers/iommu/iommu-sva.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
index 7f91c8d0064b..65814cbc8402 100644
--- a/drivers/iommu/iommu-sva.c
+++ b/drivers/iommu/iommu-sva.c
@@ -117,11 +117,11 @@ struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct mm_struct *mm
if (ret)
goto out_free_domain;
domain->users = 1;
- refcount_set(&handle->users, 1);
list_add(&domain->next, &mm->iommu_mm->sva_domains);
- list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);

out:
+ refcount_set(&handle->users, 1);
+ list_add(&handle->handle_item, &mm->iommu_mm->sva_handles);
mutex_unlock(&iommu_sva_lock);
handle->dev = dev;
handle->domain = domain;
--
2.34.1

2024-02-27 06:57:47

by Baolu Lu

Subject: Re: [PATCH rc] iommu/sva: Fix SVA handle sharing in multi device case

On 2/27/24 2:48 PM, Zhangfei Gao wrote:
> iommu_sva_bind_device will directly goto out in multi-device
> case when found existing domain, ignoring list_add handle,
> which causes the handle to fail to be shared.
>
> Fixes: 65d4418c5002 ("iommu/sva: Restore SVA handle sharing")
> Signed-off-by: Zhangfei Gao<[email protected]>
> Reviewed-by: Jason Gunthorpe<[email protected]>

Reviewed-by: Lu Baolu <[email protected]>

Best regards,
baolu

2024-02-27 07:42:54

by Tian, Kevin

Subject: RE: [PATCH rc] iommu/sva: Fix SVA handle sharing in multi device case

> From: Zhangfei Gao <[email protected]>
> Sent: Tuesday, February 27, 2024 2:48 PM
>
> iommu_sva_bind_device will directly goto out in multi-device
> case when found existing domain, ignoring list_add handle,
> which causes the handle to fail to be shared.
>
> Fixes: 65d4418c5002 ("iommu/sva: Restore SVA handle sharing")
> Signed-off-by: Zhangfei Gao <[email protected]>
> Reviewed-by: Jason Gunthorpe <[email protected]>

Reviewed-by: Kevin Tian <[email protected]>

2024-03-01 12:54:31

by Joerg Roedel

Subject: Re: [PATCH rc] iommu/sva: Fix SVA handle sharing in multi device case

On Tue, Feb 27, 2024 at 06:48:21AM +0000, Zhangfei Gao wrote:
> iommu_sva_bind_device will directly goto out in multi-device
> case when found existing domain, ignoring list_add handle,
> which causes the handle to fail to be shared.
>
> Fixes: 65d4418c5002 ("iommu/sva: Restore SVA handle sharing")
> Signed-off-by: Zhangfei Gao <[email protected]>
> Reviewed-by: Jason Gunthorpe <[email protected]>

Applied, thanks.