2020-08-19 08:44:54

by Stanley Chu

Subject: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

From: Andy Teng <[email protected]>

MediaTek UFS host starts to support 2 lanes, thus modify the
minimum lane count to 2.

This modification shall not impact old 1-lane host because
PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
target lanes properly during power mode change. So we could relax
the limitation in ufs_dev_params.

Reviewed-by: Stanley Chu <[email protected]>
Signed-off-by: Andy Teng <[email protected]>
Singed-off-by: Stanley Chu <[email protected]>
---
drivers/scsi/ufs/ufs-mediatek.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-mediatek.h b/drivers/scsi/ufs/ufs-mediatek.h
index 8ed24d5fcff9..87657376d27a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.h
+++ b/drivers/scsi/ufs/ufs-mediatek.h
@@ -33,8 +33,8 @@
/*
* Vendor specific pre-defined parameters
*/
-#define UFS_MTK_LIMIT_NUM_LANES_RX 1
-#define UFS_MTK_LIMIT_NUM_LANES_TX 1
+#define UFS_MTK_LIMIT_NUM_LANES_RX 2
+#define UFS_MTK_LIMIT_NUM_LANES_TX 2
#define UFS_MTK_LIMIT_HSGEAR_RX UFS_HS_G3
#define UFS_MTK_LIMIT_HSGEAR_TX UFS_HS_G3
#define UFS_MTK_LIMIT_PWMGEAR_RX UFS_PWM_G4
--
2.18.0

2020-08-20 06:04:52

by Avri Altman

Subject: RE: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

>
> From: Andy Teng <[email protected]>
>
> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
>
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit
> the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.
>
> Reviewed-by: Stanley Chu <[email protected]>
> Signed-off-by: Andy Teng <[email protected]>
> Singed-off-by: Stanley Chu <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

But then again, why those constants needs to be re-negotiated every pre-change?

Thanks,
Avri

2020-09-09 02:21:57

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

On Wed, 19 Aug 2020 16:43:40 +0800, Stanley Chu wrote:

> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
>
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-mediatek: Modify the minimum RX/TX lane count to 2
https://git.kernel.org/mkp/scsi/c/460d74a0911c

--
Martin K. Petersen Oracle Linux Engineering