2021-04-17 11:44:55

by Bixuan Cui

Subject: [PATCH -next] PCI: remove unused variable rdev

Fix the build warning:

drivers/pci/quirks.c: In function ‘quirk_amd_nvme_fixup’:
drivers/pci/quirks.c:312:18: warning: unused variable ‘rdev’ [-Wunused-variable]
struct pci_dev *rdev;
^~~~

Fixes: 9597624ef606 ('nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path')
Signed-off-by: Bixuan Cui <[email protected]>
---
drivers/pci/quirks.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 2e24dced699a..c86ede081534 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -309,8 +309,6 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8151_0, quirk_nopci

static void quirk_amd_nvme_fixup(struct pci_dev *dev)
{
- struct pci_dev *rdev;
-
dev->dev_flags |= PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND;
pci_info(dev, "AMD simple suspend opt enabled\n");

--
2.17.1

2021-04-17 20:38:19

by Chaitanya Kulkarni

Subject: Re: [PATCH -next] PCI: remove unused variable rdev

On 4/17/21 04:44, Bixuan Cui wrote:
> Fix the build warning:
>
> drivers/pci/quirks.c: In function ?quirk_amd_nvme_fixup?:
> drivers/pci/quirks.c:312:18: warning: unused variable ?rdev? [-Wunused-variable]
> struct pci_dev *rdev;
> ^~~~
>
> Fixes: 9597624ef606 ('nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path')
> Signed-off-by: Bixuan Cui <[email protected]>


Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>