2021-07-06 14:58:31

by Colin King

Subject: [PATCH][next] nvmet: remove redundant assignments of variable status

From: Colin Ian King <[email protected]>

There are two occurrances where variable status is being assigned a
value that is never read and it is being re-assigned a new value
almost immediately afterwards on an error exit path. The assignments
are redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/nvme/target/zns.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/nvme/target/zns.c b/drivers/nvme/target/zns.c
index 17f8b7a45f21..46bc30fe85d2 100644
--- a/drivers/nvme/target/zns.c
+++ b/drivers/nvme/target/zns.c
@@ -115,14 +115,11 @@ void nvmet_execute_identify_cns_cs_ns(struct nvmet_req *req)
}

status = nvmet_req_find_ns(req);
- if (status) {
- status = NVME_SC_INTERNAL;
+ if (status)
goto done;
- }

if (!bdev_is_zoned(req->ns->bdev)) {
req->error_loc = offsetof(struct nvme_identify, nsid);
- status = NVME_SC_INVALID_NS | NVME_SC_DNR;
goto done;
}

--
2.31.1

2021-07-06 18:31:16

by Chaitanya Kulkarni

Subject: Re: [PATCH][next] nvmet: remove redundant assignments of variable status

On 7/6/21 07:56, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There are two occurrances where variable status is being assigned a
> value that is never read and it is being re-assigned a new value
> almost immediately afterwards on an error exit path. The assignments
> are redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

For now looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

2021-07-16 07:55:32

by Christoph Hellwig

Subject: Re: [PATCH][next] nvmet: remove redundant assignments of variable status

Thanks,

applied to nvme-5.15.