2021-03-04 16:02:32

by Jiapeng Chong

Subject: [PATCH] nvme: Switch to using the new API kobj_to_dev()

Fix the following coccicheck warnings:

./drivers/nvme/host/core.c:3714:60-61: WARNING opportunity for
kobj_to_dev().

./drivers/nvme/host/core.c:3475:60-61: WARNING opportunity for
kobj_to_dev().

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/nvme/host/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index e68a8c4..89e013b 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3472,7 +3472,7 @@ static ssize_t nsid_show(struct device *dev, struct device_attribute *attr,
static umode_t nvme_ns_id_attrs_are_visible(struct kobject *kobj,
struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct nvme_ns_ids *ids = &dev_to_ns_head(dev)->ids;

if (a == &dev_attr_uuid.attr) {
@@ -3711,7 +3711,7 @@ static DEVICE_ATTR(reconnect_delay, S_IRUGO | S_IWUSR,
static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct nvme_ctrl *ctrl = dev_get_drvdata(dev);

if (a == &dev_attr_delete_controller.attr && !ctrl->ops->delete_ctrl)
--
1.8.3.1

2021-03-05 01:00:32

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvme: Switch to using the new API kobj_to_dev()

On 3/4/21 01:58, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/nvme/host/core.c:3714:60-61: WARNING opportunity for
> kobj_to_dev().
>
> ./drivers/nvme/host/core.c:3475:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
This patch is already NACKED.