2020-07-20 04:00:46

by Wang Long

Subject: [PATCH] xarray: update document for error space returned by xarray normal API

In the current xarray code, the negative value -1 and -4095 represented
as an error.

xa_is_error(xa_mk_internal(-4095)) and xa_is_error(xa_mk_internal(-1))
are all return true.

This patch update the document.

Signed-off-by: Wang Long <[email protected]>
---
include/linux/xarray.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/xarray.h b/include/linux/xarray.h
index b4d70e7..0588fb9 100644
--- a/include/linux/xarray.h
+++ b/include/linux/xarray.h
@@ -36,7 +36,7 @@
* 257: Zero entry
*
* Errors are also represented as internal entries, but use the negative
- * space (-4094 to -2). They're never stored in the slots array; only
+ * space (-4095 to -1). They're never stored in the slots array; only
* returned by the normal API.
*/

--
1.8.3.1

2020-07-20 04:08:41

by Chaitanya Kulkarni

Subject: Re: [PATCH] xarray: update document for error space returned by xarray normal API

On 7/19/20 20:58, Wang Long wrote:
> xa_is_error(xa_mk_internal(-4095)) and xa_is_error(xa_mk_internal(-1))
> are all return true.

's/xa_is_error()/xa_is_err()/` ?


Reviewed-by: Chaitanya Kulkarni <[email protected]>