2021-06-05 12:54:06

by Dan Carpenter

Subject: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()

These error paths currently return success but they should return
-EOPNOTSUPP.

Fixes: 73ffcefcfca0 ("nvme-tcp: check sgl supported by target")
Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/nvme/host/tcp.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 34f4b3402f7c..72e9d34c3092 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -1973,11 +1973,13 @@ static int nvme_tcp_setup_ctrl(struct nvme_ctrl *ctrl, bool new)
return ret;

if (ctrl->icdoff) {
+ ret = -EOPNOTSUPP;
dev_err(ctrl->device, "icdoff is not supported!\n");
goto destroy_admin;
}

if (!(ctrl->sgls & ((1 << 0) | (1 << 1)))) {
+ ret = -EOPNOTSUPP;
dev_err(ctrl->device, "Mandatory sgls are not supported!\n");
goto destroy_admin;
}
--
2.30.2

2021-06-05 18:42:11

by Chaitanya Kulkarni

Subject: Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()

On 6/5/21 05:49, Dan Carpenter wrote:
> These error paths currently return success but they should return
> -EOPNOTSUPP.
>
> Fixes: 73ffcefcfca0 ("nvme-tcp: check sgl supported by target")
> Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
> Signed-off-by: Dan Carpenter <[email protected]>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

2021-06-08 16:45:39

by Christoph Hellwig

Subject: Re: [PATCH] nvme-tcp: fix error codes in nvme_tcp_setup_ctrl()

Thanks,

applied to nvme-5.14.