2020-04-02 03:58:49

by 罗楚成

Subject: [PATCH v2] fs: Fix missing 'bit' in comment

The missing word may make it hard for other developers to
understand it.

Signed-off-by: Chucheng Luo <[email protected]>
Acked-by: Hans de Goede <[email protected]>
Acked-by: Andreas Dilger <[email protected]>
---
Changelog:
- fix missing word 'bit'
- change '32 bit' to '32-bit'
- change '64 bit' to '64-bit'
---
fs/vboxsf/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c
index dd147b490982..4d569f14a8d8 100644
--- a/fs/vboxsf/dir.c
+++ b/fs/vboxsf/dir.c
@@ -134,7 +134,7 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx)
d_type = vboxsf_get_d_type(info->info.attr.mode);

/*
- * On 32 bit systems pos is 64 signed, while ino is 32 bit
+ * On 32-bit systems pos is 64-bit signed, while ino is 32-bit
* unsigned so fake_ino may overflow, check for this.
*/
if ((ino_t)(ctx->pos + 1) != (u64)(ctx->pos + 1)) {
--
2.17.1

2020-04-02 04:12:48

by Chaitanya Kulkarni

Subject: Re: [PATCH v2] fs: Fix missing 'bit' in comment

On 4/1/20 8:58 PM, Chucheng Luo wrote:
> The missing word may make it hard for other developers to
> understand it.
>
> Signed-off-by: Chucheng Luo <[email protected]>
> Acked-by: Hans de Goede <[email protected]>
> Acked-by: Andreas Dilger <[email protected]>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>