2019-09-14 12:46:58

by Chaitanya Kulkarni

[permalink] [raw]
Subject: Re: [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro

I'm not super familier with the format, will let someone do the
final review.

In general looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

On 09/13/2019 03:04 PM, Andr? Almeida wrote:
> The pr_fmt macro is useful to format log messages printed by pr_XXXX()
> functions. Add text to explain the purpose of it, how to use and an
> example.
>
> Signed-off-by: Andr? Almeida<[email protected]>
> Cc: Jonathan Corbet<[email protected]>
> ---
> Changes from v1:
> - Add Jonathan as explict Cc
> - Replace "include/printk.h" by "#include <linux/kernel.h>
> - Add note about #undef
> - Replace hardcore string by KBUILD_MODNAME at the example
> ---