2021-09-09 13:28:19

by Sasha Levin

[permalink] [raw]
Subject: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

From: Bob Moore <[email protected]>

[ Upstream commit 87b8ec5846cb81747088d1729acaf55a1155a267 ]

Handle the case where the Command-line Arguments table field
does not exist.

ACPICA commit d6487164497fda170a1b1453c5d58f2be7c873d6

Link: https://github.com/acpica/acpica/commit/d6487164
Signed-off-by: Bob Moore <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
include/acpi/actbl3.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
index 1df891660f43..81d5ebc886f5 100644
--- a/include/acpi/actbl3.h
+++ b/include/acpi/actbl3.h
@@ -738,6 +738,10 @@ struct acpi_table_wpbt {
u16 arguments_length;
};

+struct acpi_wpbt_unicode {
+ u16 *unicode_string;
+};
+
/*******************************************************************************
*
* XENV - Xen Environment Table (ACPI 6.0)
--
2.30.2


2021-09-10 07:47:52

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

Hi!

> Handle the case where the Command-line Arguments table field
> does not exist.
>
> ACPICA commit d6487164497fda170a1b1453c5d58f2be7c873d6

I'm not sure what is going on here, but adding unused definition will
not make any difference for 4.4 users, so we don't need this in
-stable...?

Best regards,
Pavel

> +++ b/include/acpi/actbl3.h
> @@ -738,6 +738,10 @@ struct acpi_table_wpbt {
> u16 arguments_length;
> };
>
> +struct acpi_wpbt_unicode {
> + u16 *unicode_string;
> +};
> +
> /*******************************************************************************
> *
> * XENV - Xen Environment Table (ACPI 6.0)

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (813.00 B)
signature.asc (188.00 B)
Digital signature
Download all attachments

2021-09-11 14:41:08

by Sasha Levin

[permalink] [raw]
Subject: Re: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

On Fri, Sep 10, 2021 at 09:45:36AM +0200, Pavel Machek wrote:
>Hi!
>
>> Handle the case where the Command-line Arguments table field
>> does not exist.
>>
>> ACPICA commit d6487164497fda170a1b1453c5d58f2be7c873d6
>
>I'm not sure what is going on here, but adding unused definition will
>not make any difference for 4.4 users, so we don't need this in
>-stable...?

Ugh, dropped, thanks!

I wonder what this patch actually does upstream.

--
Thanks,
Sasha

2021-09-13 12:23:19

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

On Sat, Sep 11, 2021 at 4:38 PM Sasha Levin <[email protected]> wrote:
>
> On Fri, Sep 10, 2021 at 09:45:36AM +0200, Pavel Machek wrote:
> >Hi!
> >
> >> Handle the case where the Command-line Arguments table field
> >> does not exist.
> >>
> >> ACPICA commit d6487164497fda170a1b1453c5d58f2be7c873d6
> >
> >I'm not sure what is going on here, but adding unused definition will
> >not make any difference for 4.4 users, so we don't need this in
> >-stable...?
>
> Ugh, dropped, thanks!
>
> I wonder what this patch actually does upstream.

There are AML compiler changes in it, but the compiler is not included
into the Linux kernel.

2021-09-18 08:21:17

by Moore, Robert

[permalink] [raw]
Subject: RE: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

This structure is used by the iASL data table disassembler.
Bob


-----Original Message-----
From: Pavel Machek <[email protected]>
Sent: Friday, September 10, 2021 12:46 AM
To: Sasha Levin <[email protected]>
Cc: [email protected]; [email protected]; Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH AUTOSEL 4.4 24/35] ACPICA: iASL: Fix for WPBT table with no command-line arguments

Hi!

> Handle the case where the Command-line Arguments table field does not
> exist.
>
> ACPICA commit d6487164497fda170a1b1453c5d58f2be7c873d6

I'm not sure what is going on here, but adding unused definition will not make any difference for 4.4 users, so we don't need this in -stable...?

Best regards,
Pavel

> +++ b/include/acpi/actbl3.h
> @@ -738,6 +738,10 @@ struct acpi_table_wpbt {
> u16 arguments_length;
> };
>
> +struct acpi_wpbt_unicode {
> + u16 *unicode_string;
> +};
> +
> /*******************************************************************************
> *
> * XENV - Xen Environment Table (ACPI 6.0)

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany