2020-02-10 23:35:57

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the drivers-x86 tree

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-Wint-conversion]
1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
| ^~~~~~~~
| |
| char *
drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'char *'
978 | struct seq_file *s, u32 offset,
| ~~~~^~~~~~
drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-Wint-conversion]
1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
| ^~~~~~
| |
| int
drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *' but argument is of type 'int'
979 | const char *str,
| ~~~~~~~~~~~~^~~

Introduced by commit

2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status registers on an S0ix.y failure")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-02-10 23:40:13

by Kammela, Gayatri

[permalink] [raw]
Subject: RE: linux-next: build warning after merge of the drivers-x86 tree

> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: Monday, February 10, 2020 3:36 PM
> To: Darren Hart <[email protected]>; Andy Shevchenko
> <[email protected]>
> Cc: Linux Next Mailing List <[email protected]>; Linux Kernel
> Mailing List <[email protected]>; Kammela, Gayatri
> <[email protected]>
> Subject: linux-next: build warning after merge of the drivers-x86 tree
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
> drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument
> 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-
> Wint-conversion]
> 1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset,
> maps);
> | ^~~~~~~~
> | |
> | char *
> drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka
> 'unsigned int'} but argument is of type 'char *'
> 978 | struct seq_file *s, u32 offset,
> | ~~~~^~~~~~
> drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument
> 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-
> Wint-conversion]
> 1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset,
> maps);
> | ^~~~~~
> | |
> | int
> drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *'
> but argument is of type 'int'
> 979 | const char *str,
> | ~~~~~~~~~~~~^~~
>
> Introduced by commit
>
> 2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status
> registers on an S0ix.y failure")
>
Hi Stephen,
Thanks for reporting the warning!. I have already sent a fix up patch earlier this morning.
> --
> Cheers,
> Stephen Rothwell

2020-02-11 21:42:42

by Andy Shevchenko

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the drivers-x86 tree

On Tue, Feb 11, 2020 at 1:35 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
> drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-Wint-conversion]
> 1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
> | ^~~~~~~~
> | |
> | char *
> drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'char *'
> 978 | struct seq_file *s, u32 offset,
> | ~~~~^~~~~~
> drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-Wint-conversion]
> 1329 | pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
> | ^~~~~~
> | |
> | int
> drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *' but argument is of type 'int'
> 979 | const char *str,
> | ~~~~~~~~~~~~^~~
>
> Introduced by commit
>
> 2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status registers on an S0ix.y failure")

Thank you, Stephen,
Fix had been incorporated.


--
With Best Regards,
Andy Shevchenko