2022-07-20 11:52:02

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string

On 20/07/2022 13:29, Harini Katakam wrote:
> From: Radhey Shyam Pandey <[email protected]>
>
> Add versal compatible string.
>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> Signed-off-by: Harini Katakam <[email protected]>
> ---
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 9c92156869b2..1e9f49bb8249 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -22,6 +22,7 @@ properties:
> - enum:
> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
> + - cdns,versal-gem # Xilinx Versal

Not really ordered by name. Why adding to the end?

Best regards,
Krzysztof

2022-07-20 12:04:35

by Harini Katakam

Subject: RE: [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string

Hi Krzysztof,

<snip>
> > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > index 9c92156869b2..1e9f49bb8249 100644
> > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > @@ -22,6 +22,7 @@ properties:
> > - enum:
> > - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
> > - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
> > + - cdns,versal-gem # Xilinx Versal
>
> Not really ordered by name. Why adding to the end?

Thanks for the review. It is just based on the order in which device
families from Xilinx were released. I can alphabetize if that's preferred.

Regards,
Harini

2022-07-20 12:10:24

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: net: cdns,macb: Add versal compatible string

On 20/07/2022 13:36, Katakam, Harini wrote:
>>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> index 9c92156869b2..1e9f49bb8249 100644
>>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>> @@ -22,6 +22,7 @@ properties:
>>> - enum:
>>> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
>>> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
>>> + - cdns,versal-gem # Xilinx Versal
>>
>> Not really ordered by name. Why adding to the end?
>
> Thanks for the review. It is just based on the order in which device
> families from Xilinx were released. I can alphabetize if that's preferred.

Yes, it's the easiest way to avoid conflicts.

Best regards,
Krzysztof