2022-02-08 23:32:26

by Bird, Tim

[permalink] [raw]
Subject: RE: [PATCH v2 1/1] Documentation: dev-tools: clarify KTAP specification wording



> -----Original Message-----
> From: Frank Rowand <[email protected]>
>
> On 2/7/22 10:38 AM, Frank Rowand wrote:
> > On 2/7/22 10:28 AM, [email protected] wrote:
> >> From: Frank Rowand <[email protected]>
> >>
> >> Add the spec version to the title line.
> >>
> >> Explain likely source of "Unknown lines".
> >>
> >> "Unknown lines" in nested tests are optionally indented.
> >>
> >> Add "Unknown lines" items to differences between TAP & KTAP list
> >>
> >> Signed-off-by: Frank Rowand <[email protected]>
> >> ---
> >
> > Please do not apply this version (v2). I was working off the KTAP specification
> ^^^^ TAP

What???

> > from a different github repo than I should have been referencing.
>
> OK to proceed with this version of the patch. I was referencing the proposed
> TAP version 14, which is in a different github repo than the TAP version 13
> specification. Everything in this patch is consistent with TAP version 13,
> as well as the proposed TAP version 14.

I'm confused by this message.
Will there be a v3 of the patch, or are you saying to just apply the original v2 of
this patch?

For the original (v2) of the patch, which I believe is
https://lore.kernel.org/all/[email protected]/

you can add a "Reviewed-by" from me.
-- Tim