2022-04-22 20:03:52

by icenowy

Subject: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding

From: Icenowy Zheng <[email protected]>

R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
and reset.

Add binding for it.

Signed-off-by: Icenowy Zheng <[email protected]>
---
.../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
index d74f2002409e..e16f01510ea7 100644
--- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
+++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
@@ -15,6 +15,7 @@ properties:
oneOf:
- const: allwinner,sun4i-a10-lradc-keys
- const: allwinner,sun8i-a83t-r-lradc
+ - const: allwinner,sun50i-r329-lradc
- items:
- const: allwinner,sun50i-a64-lradc
- const: allwinner,sun8i-a83t-r-lradc
@@ -31,6 +32,26 @@ properties:

wakeup-source: true

+if:
+ properties:
+ compatible:
+ const: allwinner,sun50i-r329-lradc
+then:
+ properties:
+ clocks:
+ description:
+ Bus clock gate for LRADC.
+ maxItems: 1
+
+ resets:
+ description:
+ Bus reset for LRADC.
+ maxItems: 1
+
+ required:
+ - clocks
+ - resets
+
patternProperties:
"^button-[0-9]+$":
type: object
--
2.35.1

2022-04-22 23:14:29

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding

On Sat, 23 Apr 2022 00:07:43 +0800, [email protected] wrote:
> From: Icenowy Zheng <[email protected]>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <[email protected]>
> ---
> .../input/allwinner,sun4i-a10-lradc-keys.yaml | 21 +++++++++++++++++++
> 1 file changed, 21 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: then:properties:required: ['clocks', 'resets'] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml: ignoring, error in schema: then: properties: required
Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.example.dtb:0:0: /example-0/lradc@1c22800: failed to match any schema with compatible: ['allwinner,sun4i-a10-lradc-keys']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2022-04-23 00:18:02

by Samuel Holland

Subject: Re: [PATCH 1/2] dt-bindings: input: sun4i-lradc-keys: add R329 LRADC binding

Hi Icenowy,

On 4/22/22 11:07 AM, [email protected] wrote:
> From: Icenowy Zheng <[email protected]>
>
> R329 has similar LRADC with previous Allwinner SoCs, but with bus clock
> and reset.
>
> Add binding for it.
>
> Signed-off-by: Icenowy Zheng <[email protected]>

I sent this binding/driver update (also with D1 support) last week:

https://lore.kernel.org/lkml/[email protected]/T/

Please see if it works for you.

Regards,
Samuel