2012-08-22 12:39:46

by Bob Tracy

[permalink] [raw]
Subject: [BUG] net/core/sock.c won't compile on alpha

Kernel version 3.6.0-rc2, and probably -rc1 as well. I get the
following compile-time error on alpha architecture:

(...)
CC net/core/sock.o
net/core/sock.c:274:36: error: initializer element is not constant
net/core/sock.c:274:36: error: (near initialization for "memalloc_socks")
net/core/sock.c:274:36: error: initializer element is not constant
make[2]: *** [net/core/sock.o] Error 1
make[1]: *** [net/core] Error 2
make: *** [net] Error 2

Compiler is gcc-4.6.3.

Line 274 of net/core/sock.c is

struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE;

which made its first appearance in 3.6.0-rc1.

--Bob


2012-08-22 21:17:16

by Michael Cree

[permalink] [raw]
Subject: Re: [BUG] net/core/sock.c won't compile on alpha

On 23/08/2012, at 12:14 AM, Bob Tracy wrote:
> Kernel version 3.6.0-rc2, and probably -rc1 as well. I get the
> following compile-time error on alpha architecture:
>
> (...)
> CC net/core/sock.o
> net/core/sock.c:274:36: error: initializer element is not constant

Try v3.6-rc3. It should be fixed now.

Cheers
Michael.

2012-08-23 05:20:15

by Bob Tracy

[permalink] [raw]
Subject: Re: [BUG] net/core/sock.c won't compile on alpha

On Thu, Aug 23, 2012 at 09:16:53AM +1200, Michael Cree wrote:
> On 23/08/2012, at 12:14 AM, Bob Tracy wrote:
> >Kernel version 3.6.0-rc2, and probably -rc1 as well. I get the
> >following compile-time error on alpha architecture:
> >
> >(...)
> > CC net/core/sock.o
> >net/core/sock.c:274:36: error: initializer element is not constant
>
> Try v3.6-rc3. It should be fixed now.

That got it. Finally saw the discussion on the bug (from about a month
ago -- thanks, Simon).

--Bob