2019-02-04 18:43:17

by Eugeniy Paltsev

Subject: [PATCH] ARC: fix actionpoints configuration detection

Fix reversed logic while actionpoints configuration (full/min)
detection.

Fixies: 7dd380c338f1e ("ARC: boot log: print Action point details")
Signed-off-by: Eugeniy Paltsev <[email protected]>
---
arch/arc/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index feb90093e6b1..def19b0ef8c6 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -212,7 +212,7 @@ static void read_arc_build_cfg_regs(void)
READ_BCR(ARC_REG_AP_BCR, ap);
if (ap.ver) {
cpu->extn.ap_num = 2 << ap.num;
- cpu->extn.ap_full = !!ap.min;
+ cpu->extn.ap_full = !ap.min;
}

READ_BCR(ARC_REG_SMART_BCR, bcr);
--
2.14.5

2019-02-05 17:01:02

by Vineet Gupta

Subject: Re: [PATCH] ARC: fix actionpoints configuration detection

On 2/4/19 10:41 AM, Eugeniy Paltsev wrote:
> Fix reversed logic while actionpoints configuration (full/min)
> detection.
>
> Fixies: 7dd380c338f1e ("ARC: boot log: print Action point details")
> Signed-off-by: Eugeniy Paltsev <[email protected]>

LGTM.

Thx,
-vineet


> ---
> arch/arc/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index feb90093e6b1..def19b0ef8c6 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -212,7 +212,7 @@ static void read_arc_build_cfg_regs(void)
> READ_BCR(ARC_REG_AP_BCR, ap);
> if (ap.ver) {
> cpu->extn.ap_num = 2 << ap.num;
> - cpu->extn.ap_full = !!ap.min;
> + cpu->extn.ap_full = !ap.min;
> }
>
> READ_BCR(ARC_REG_SMART_BCR, bcr);