On Thursday 27 August 2015 12:28 PM, Alexey Brodkin wrote:
> Hi Peter,
>
> On Wed, 2015-08-26 at 12:07 +0000, Alexey Brodkin wrote:
>> > Hi Peter,
>> >
>> > On Mon, 2015-08-24 at 17:20 +0300, Alexey Brodkin wrote:
>>> > > Hi Peter,
>>> > >
>>> > > This mini-series adds perf support for ARCv2 based cores, which brings in
>>> > > overflow interupts and SMP. Additionally now raw events are supported as well.
>>> > >
>>> > > Please review !
>>> > >
>>> > > Compared to v2 this series has:
>>> > > [1] Removed patch with raw-events support.
>>> > > It needs some rework and let's then discuss it separately.
>>> > > Still I plan to send it shortly.
>>> > > [2] Merged "set usable max period as a half of real max period" into
>>> > > "implement "event_set_period".
>>> > > [3] Fixed arc_pmu_event_set_period() in regard of incorrect
>>> > > "hwc->period_left" setup.
>>> > > [4] Moved interrupts enabling from arc_pmu_add() to arc_pmu_start()
>>> > >
>>> > > Compared to v1 this series has:
>>> > > [1] Addressed review comments
>>> > > [2] More verbose commit messages and comments in sources
>>> > > [3] Minor cosmetics
>>> > >
>>> > > Thanks,
>>> > > Alexey
> I'm wondering if you have any other comments on this series,
> otherwise please consider it for applying.
IMO it is better if this goes via ARC tree !
-Vineet
>
> -Alexey
On Thu, Aug 27, 2015 at 07:14:52AM +0000, Vineet Gupta wrote:
> On Thursday 27 August 2015 12:28 PM, Alexey Brodkin wrote:
> > I'm wondering if you have any other comments on this series,
> > otherwise please consider it for applying.
>
> IMO it is better if this goes via ARC tree !
>
I agree, please take it through the ARC tree.
The code looks good and the issues that I found were concious choices
that I see no real problems with.
Acked-by: Peter Zijlstra (Intel) <[email protected]>