2013-05-30 10:26:39

by Yijing Wang

Subject: [PATCH 6/7] qlcnic: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0,
so it's no need to do it again in qlcnic_attach_func().

Signed-off-by: Yijing Wang <[email protected]>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index aeb26a8..3585c2c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev *pdev)
if (err)
return err;

- pci_set_power_state(pdev, PCI_D0);
pci_set_master(pdev);
pci_restore_state(pdev);

--
1.7.1

2013-05-31 13:49:29

by Rajesh Borundia

Subject: RE: [PATCH 6/7] qlcnic: remove redundant D0 power state set

>-----Original Message-----
>From: Yijing Wang [mailto:[email protected]]
>Sent: Thursday, May 30, 2013 3:56 PM
>To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko
>Cc: linux-kernel; Dept-Eng Linux Driver; netdev; Hanjun Guo; Jiang Liu;
>Yijing Wang
>Subject: [PATCH 6/7] qlcnic: remove redundant D0 power state set
>
>Pci_enable_device() will set device power state to D0,
>so it's no need to do it again in qlcnic_attach_func().
>
>Signed-off-by: Yijing Wang <[email protected]>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>index aeb26a8..3585c2c 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev
>*pdev)
> if (err)
> return err;
>
>- pci_set_power_state(pdev, PCI_D0);
> pci_set_master(pdev);
> pci_restore_state(pdev);
>
>--
>1.7.1
>
>

Acked-by: Rajesh Borundia <[email protected]>

Thanks!