2014-12-02 10:50:29

by Sudip Mukherjee

Subject: [PATCH v2] staging: unisys: remove duplicate header

these header files were included multiple times

Signed-off-by: Sudip Mukherjee <[email protected]>
---

change in v2: missed seeing that linux/uuid.h is included 3 times

drivers/staging/unisys/include/timskmod.h | 1 -
drivers/staging/unisys/uislib/uisutils.c | 2 --
2 files changed, 3 deletions(-)

diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/include/timskmod.h
index de11f44..cff7983 100644
--- a/drivers/staging/unisys/include/timskmod.h
+++ b/drivers/staging/unisys/include/timskmod.h
@@ -31,7 +31,6 @@
#include <linux/slab.h>
#include <linux/errno.h>
#include <linux/interrupt.h>
-#include <linux/sched.h>
#include <linux/wait.h>
#include <linux/vmalloc.h>
#include <linux/proc_fs.h>
diff --git a/drivers/staging/unisys/uislib/uisutils.c b/drivers/staging/unisys/uislib/uisutils.c
index a8466e3..4a5b867 100644
--- a/drivers/staging/unisys/uislib/uisutils.c
+++ b/drivers/staging/unisys/uislib/uisutils.c
@@ -25,9 +25,7 @@
#include "uisutils.h"
#include "version.h"
#include "vbushelper.h"
-#include <linux/uuid.h>
#include <linux/skbuff.h>
-#include <linux/uuid.h>
#ifdef CONFIG_HIGHMEM
#include <linux/highmem.h>
#endif
--
1.8.1.2

2014-12-02 15:37:11

by Ben Romer

Subject: Re: [PATCH v2] staging: unisys: remove duplicate header

On Tue, 2014-12-02 at 16:20 +0530, Sudip Mukherjee wrote:
> these header files were included multiple times
>
> Signed-off-by: Sudip Mukherjee <[email protected]>

Looks good to me, thanks for the help. :)

Signed-off-by: Benjamin Romer <[email protected]>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?