2012-05-02 13:41:39

by Josh Boyer

[permalink] [raw]
Subject: Re: [V2 2/5] powerpc: 40x: Add AHB, APB of_device_ids

On Mon, Apr 9, 2012 at 3:20 AM, Tanmay Inamdar <[email protected]> wrote:
> Adding of_device_id's for AHB and APB buses used in klondike (APM8018X) in
> platforms/40x/ppc40x_simple.c file
>
> Signed-off-by: Tanmay Inamdar <[email protected]>

You should probably combine the first 3 patches in this series into one
patch. Otherwise you run the risk of changing the DTS to something the
kernel can't support. At the least, this change should be patch 1 in
the series, and you can probably combine the two DTS changes.

josh


2012-05-09 05:28:49

by Tanmay Inamdar

[permalink] [raw]
Subject: Re: [V2 2/5] powerpc: 40x: Add AHB, APB of_device_ids

On Wed, May 2, 2012 at 7:11 PM, Josh Boyer <[email protected]> wrote:
> On Mon, Apr 9, 2012 at 3:20 AM, Tanmay Inamdar <[email protected]> wrote:
>> Adding of_device_id's for AHB and APB buses used in klondike (APM8018X) in
>> platforms/40x/ppc40x_simple.c file
>>
>> Signed-off-by: Tanmay Inamdar <[email protected]>
>
> You should probably combine the first 3 patches in this series into one
> patch. ?Otherwise you run the risk of changing the DTS to something the
> kernel can't support. ?At the least, this change should be patch 1 in
> the series, and you can probably combine the two DTS changes.
>

I will do it in next version of patches.

> josh

Thanks,
Tanmay
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,
is for the sole use of the intended recipient(s) and contains information?
that is confidential and proprietary to AppliedMicro Corporation or its subsidiaries.
It is to be used solely for the purpose of furthering the parties' business relationship.
All unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by reply e-mail
and destroy all copies of the original message.