2022-04-21 13:56:26

by Anshuman Khandual

Subject: [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL()

Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In
this case these functions just get called only inside their wrappers. Even
__page_table_check_zero() gets called without such an export. Just drop all
these redundant EXPORT_SYMBOL().

Cc: Pasha Tatashin <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
---
This applies on v5.18-rc3

Changes in V2:

- Restored EXPORT_SYMBOL for __page_table_check_pte_set() per Pasha

mm/page_table_check.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/mm/page_table_check.c b/mm/page_table_check.c
index 2458281bff89..627c5025d786 100644
--- a/mm/page_table_check.c
+++ b/mm/page_table_check.c
@@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr,
PAGE_SIZE >> PAGE_SHIFT);
}
}
-EXPORT_SYMBOL(__page_table_check_pte_clear);

void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
pmd_t pmd)
@@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
PMD_PAGE_SIZE >> PAGE_SHIFT);
}
}
-EXPORT_SYMBOL(__page_table_check_pmd_clear);

void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
pud_t pud)
@@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
PUD_PAGE_SIZE >> PAGE_SHIFT);
}
}
-EXPORT_SYMBOL(__page_table_check_pud_clear);

void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,
pte_t *ptep, pte_t pte)
@@ -223,7 +220,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
pmd_write(pmd));
}
}
-EXPORT_SYMBOL(__page_table_check_pmd_set);

void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
pud_t *pudp, pud_t pud)
@@ -238,7 +234,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
pud_write(pud));
}
}
-EXPORT_SYMBOL(__page_table_check_pud_set);

void __page_table_check_pte_clear_range(struct mm_struct *mm,
unsigned long addr,
--
2.20.1

2022-04-22 17:21:29

by Pasha Tatashin

Subject: Re: [PATCH V2] mm/page_table_check: Drop all redundant EXPORT_SYMBOL()

On Thu, Apr 21, 2022 at 3:05 AM Anshuman Khandual
<[email protected]> wrote:
>
> Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In
> this case these functions just get called only inside their wrappers. Even
> __page_table_check_zero() gets called without such an export. Just drop all
> these redundant EXPORT_SYMBOL().
>
> Cc: Pasha Tatashin <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Anshuman Khandual <[email protected]>

Acked-by: Pasha Tatashin <[email protected]>

Thank you,
Pasha

> ---
> This applies on v5.18-rc3
>
> Changes in V2:
>
> - Restored EXPORT_SYMBOL for __page_table_check_pte_set() per Pasha
>
> mm/page_table_check.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/mm/page_table_check.c b/mm/page_table_check.c
> index 2458281bff89..627c5025d786 100644
> --- a/mm/page_table_check.c
> +++ b/mm/page_table_check.c
> @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr,
> PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pte_clear);
>
> void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
> pmd_t pmd)
> @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr,
> PMD_PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pmd_clear);
>
> void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
> pud_t pud)
> @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr,
> PUD_PAGE_SIZE >> PAGE_SHIFT);
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pud_clear);
>
> void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr,
> pte_t *ptep, pte_t pte)
> @@ -223,7 +220,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr,
> pmd_write(pmd));
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pmd_set);
>
> void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
> pud_t *pudp, pud_t pud)
> @@ -238,7 +234,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr,
> pud_write(pud));
> }
> }
> -EXPORT_SYMBOL(__page_table_check_pud_set);
>
> void __page_table_check_pte_clear_range(struct mm_struct *mm,
> unsigned long addr,
> --
> 2.20.1
>