2020-01-06 17:23:57

by Frank Lee

Subject: [PATCH 1/2] thermal: sun8i: fix r40 ths number

According to the spec, r40 has 2 thermal sensors.
Sensor0 located in the CPU, another in the GPU.

Signed-off-by: Yangtao Li <[email protected]>
Tested-by: Corentin Labbe <[email protected]>
Tested-on: sun8i-r40-bananapi-m2-ultra
---
drivers/thermal/sun8i_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
index 23a5f4aa4be4..c5661d7c3e20 100644
--- a/drivers/thermal/sun8i_thermal.c
+++ b/drivers/thermal/sun8i_thermal.c
@@ -565,7 +565,7 @@ static const struct ths_thermal_chip sun8i_h3_ths = {
};

static const struct ths_thermal_chip sun8i_r40_ths = {
- .sensor_num = 3,
+ .sensor_num = 2,
.offset = 251086,
.scale = 1130,
.has_mod_clk = true,
--
2.17.1

2020-01-06 17:30:19

by Vasily Khoruzhick

Subject: Re: [PATCH 1/2] thermal: sun8i: fix r40 ths number

On Mon, Jan 6, 2020 at 9:23 AM Yangtao Li <[email protected]> wrote:
>
> According to the spec, r40 has 2 thermal sensors.
> Sensor0 located in the CPU, another in the GPU.
>
> Signed-off-by: Yangtao Li <[email protected]>

You should also add "Fixes" tag here.

> Tested-by: Corentin Labbe <[email protected]>
> Tested-on: sun8i-r40-bananapi-m2-ultra
> ---
> drivers/thermal/sun8i_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 23a5f4aa4be4..c5661d7c3e20 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -565,7 +565,7 @@ static const struct ths_thermal_chip sun8i_h3_ths = {
> };
>
> static const struct ths_thermal_chip sun8i_r40_ths = {
> - .sensor_num = 3,
> + .sensor_num = 2,
> .offset = 251086,
> .scale = 1130,
> .has_mod_clk = true,
> --
> 2.17.1
>

2020-01-06 17:46:23

by Frank Lee

Subject: Re: [PATCH 1/2] thermal: sun8i: fix r40 ths number

On Tue, Jan 7, 2020 at 1:29 AM Vasily Khoruzhick <[email protected]> wrote:
>
> On Mon, Jan 6, 2020 at 9:23 AM Yangtao Li <[email protected]> wrote:
> >
> > According to the spec, r40 has 2 thermal sensors.
> > Sensor0 located in the CPU, another in the GPU.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
>
> You should also add "Fixes" tag here.

Since the driver has not yet entered the merge window......
Thanks for reminding， ：D

Yangtao

>
> > Tested-by: Corentin Labbe <[email protected]>
> > Tested-on: sun8i-r40-bananapi-m2-ultra
> > ---
> > drivers/thermal/sun8i_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> > index 23a5f4aa4be4..c5661d7c3e20 100644
> > --- a/drivers/thermal/sun8i_thermal.c
> > +++ b/drivers/thermal/sun8i_thermal.c
> > @@ -565,7 +565,7 @@ static const struct ths_thermal_chip sun8i_h3_ths = {
> > };
> >
> > static const struct ths_thermal_chip sun8i_r40_ths = {
> > - .sensor_num = 3,
> > + .sensor_num = 2,
> > .offset = 251086,
> > .scale = 1130,
> > .has_mod_clk = true,
> > --
> > 2.17.1
> >