2020-04-07 06:51:58

by Vasily Khoruzhick

Subject: Re: [PATCH v2 2/3] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree

On Mon, Apr 6, 2020 at 10:58 PM Alistair Francis <[email protected]> wrote:
>
> From: Vasily Khoruzhick <[email protected]>
>
> RTL8723BS is often used in ARM boards, so add ability to bind it
> using device tree.
>
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> Signed-off-by: Alistair Francis <[email protected]>
> ---
> drivers/bluetooth/hci_h5.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 106c110efe56..b0e25a7ca850 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -1019,6 +1019,8 @@ static const struct of_device_id rtl_bluetooth_of_match[] = {
> { .compatible = "realtek,rtl8822cs-bt",
> .data = (const void *)&rtl_vnd },
> #endif
> + { .compatible = "realtek,rtl8822bs-bt",

Wrong compatible? Also you probably want to keep it over #endif.

> + .data = (const void *)&rtl_vnd },
> { },
> };
> MODULE_DEVICE_TABLE(of, rtl_bluetooth_of_match);
> --
> 2.25.1
>

2020-04-08 02:41:52

by Alistair Francis

Subject: Re: [PATCH v2 2/3] Bluetooth: hci_h5: Add support for binding RTL8723BS with device tree

On Mon, Apr 6, 2020 at 11:51 PM Vasily Khoruzhick <[email protected]> wrote:
>
> On Mon, Apr 6, 2020 at 10:58 PM Alistair Francis <[email protected]> wrote:
> >
> > From: Vasily Khoruzhick <[email protected]>
> >
> > RTL8723BS is often used in ARM boards, so add ability to bind it
> > using device tree.
> >
> > Signed-off-by: Vasily Khoruzhick <[email protected]>
> > Signed-off-by: Alistair Francis <[email protected]>
> > ---
> > drivers/bluetooth/hci_h5.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> > index 106c110efe56..b0e25a7ca850 100644
> > --- a/drivers/bluetooth/hci_h5.c
> > +++ b/drivers/bluetooth/hci_h5.c
> > @@ -1019,6 +1019,8 @@ static const struct of_device_id rtl_bluetooth_of_match[] = {
> > { .compatible = "realtek,rtl8822cs-bt",
> > .data = (const void *)&rtl_vnd },
> > #endif
> > + { .compatible = "realtek,rtl8822bs-bt",
>
> Wrong compatible? Also you probably want to keep it over #endif.

Fixed.

Alistair

>
> > + .data = (const void *)&rtl_vnd },
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, rtl_bluetooth_of_match);
> > --
> > 2.25.1
> >