Since ANX6345 driver has been merged we can add support for Pinebook LCD
This is a follow up on [1] which attempted to add support for all the
A64-based Pinebooks.
Since patches for 768p were dropped we don't need edp-connector binding
discussed in [1] and its earlier versions and we can use panel-simple
binding as everyone else does.
If we ever going to add support for 768p we can do it through dt-overlay
with appropriate panel node or by teaching bootloader to patch dtb with
correct panel compatible.
Similar approach was chosen in [2]
[1] https://patchwork.kernel.org/cover/10814169/
[2] https://patchwork.kernel.org/patch/11277765/
v2:
- Collect r-b tags
- Don't print devm_regulator_get() error only if it is -EPROBE_DEFER
- Keep compatibles alphabetically sorted in panel-simple.yaml
- Properly indent new panel modes
- Drop #address-cells, #size-cells properties and @0 suffix
of endpoints in sun50i-a64-pinebook.dts
Icenowy Zheng (1):
arm64: allwinner: a64: enable LCD-related hardware for Pinebook
Samuel Holland (1):
drm/bridge: anx6345: Fix getting anx6345 regulators
Vasily Khoruzhick (4):
drm/bridge: anx6345: don't print error message if regulator is not
ready
dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor
prefix
dt-bindings: display: simple: Add NewEast Optoelectronics WJFH116008A
compatible
drm/panel: simple: Add NewEast Optoelectronics CO., LTD WJFH116008A
panel support
.../bindings/display/panel/panel-simple.yaml | 2 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
.../dts/allwinner/sun50i-a64-pinebook.dts | 61 ++++++++++++++++++-
.../drm/bridge/analogix/analogix-anx6345.c | 12 ++--
drivers/gpu/drm/panel/panel-simple.c | 48 +++++++++++++++
5 files changed, 120 insertions(+), 5 deletions(-)
--
2.25.0
Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
Signed-off-by: Vasily Khoruzhick <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 6456a6dfd83d..5dfbad67aa81 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -661,6 +661,8 @@ patternProperties:
description: Netron DY
"^netxeon,.*":
description: Shenzhen Netxeon Technology CO., LTD
+ "^neweast,.*":
+ description: Guangdong Neweast Optoelectronics CO., LTD
"^nexbox,.*":
description: Nexbox
"^nextthing,.*":
--
2.25.0
From: Samuel Holland <[email protected]>
We don't need to pass '-supply' suffix to devm_regulator_get()
Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Samuel Holland <[email protected]>
Signed-off-by: Vasily Khoruzhick <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 56f55c53abfd..0d8d083b0207 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
DRM_DEBUG("No panel found\n");
/* 1.2V digital core power regulator */
- anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
+ anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
if (IS_ERR(anx6345->dvdd12)) {
DRM_ERROR("dvdd12-supply not found\n");
return PTR_ERR(anx6345->dvdd12);
}
/* 2.5V digital core power regulator */
- anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
+ anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
if (IS_ERR(anx6345->dvdd25)) {
DRM_ERROR("dvdd25-supply not found\n");
return PTR_ERR(anx6345->dvdd25);
--
2.25.0
We don't want to print scary message if devm_regulator_get() returns
-EPROBE_DEFER
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Vasily Khoruzhick <[email protected]>
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
index 0d8d083b0207..0bf81b9b5faa 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -714,14 +714,18 @@ static int anx6345_i2c_probe(struct i2c_client *client,
/* 1.2V digital core power regulator */
anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
if (IS_ERR(anx6345->dvdd12)) {
- DRM_ERROR("dvdd12-supply not found\n");
+ if (PTR_ERR(anx6345->dvdd12) != -EPROBE_DEFER)
+ DRM_ERROR("Failed to get dvdd12 supply (%ld)\n",
+ PTR_ERR(anx6345->dvdd12));
return PTR_ERR(anx6345->dvdd12);
}
/* 2.5V digital core power regulator */
anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
if (IS_ERR(anx6345->dvdd25)) {
- DRM_ERROR("dvdd25-supply not found\n");
+ if (PTR_ERR(anx6345->dvdd25) != -EPROBE_DEFER)
+ DRM_ERROR("Failed to get dvdd25 supply (%ld)\n",
+ PTR_ERR(anx6345->dvdd25));
return PTR_ERR(anx6345->dvdd25);
}
--
2.25.0
On Wed, Feb 26, 2020 at 12:10:08AM -0800, Vasily Khoruzhick wrote:
> Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
>
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Rob Herring <[email protected]>
On Wed, Feb 26, 2020 at 12:10 AM Vasily Khoruzhick <[email protected]> wrote:
>
> From: Samuel Holland <[email protected]>
This patch can be dropped since equivalent was merged:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6726ca1a2d531f5a6efc1f785b15606ce837c4dc
> We don't need to pass '-supply' suffix to devm_regulator_get()
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Samuel Holland <[email protected]>
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> index 56f55c53abfd..0d8d083b0207 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
> DRM_DEBUG("No panel found\n");
>
> /* 1.2V digital core power regulator */
> - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
> + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
> if (IS_ERR(anx6345->dvdd12)) {
> DRM_ERROR("dvdd12-supply not found\n");
> return PTR_ERR(anx6345->dvdd12);
> }
>
> /* 2.5V digital core power regulator */
> - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
> + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
> if (IS_ERR(anx6345->dvdd25)) {
> DRM_ERROR("dvdd25-supply not found\n");
> return PTR_ERR(anx6345->dvdd25);
> --
> 2.25.0
>