2020-02-20 08:36:23

by Vasily Khoruzhick

[permalink] [raw]
Subject: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD

Signed-off-by: Vasily Khoruzhick <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 6456a6dfd83d..a390a793422b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -665,6 +665,8 @@ patternProperties:
description: Nexbox
"^nextthing,.*":
description: Next Thing Co.
+ "^neweast,.*":
+ description: Guangdong Neweast Optoelectronics CO., LT
"^newhaven,.*":
description: Newhaven Display International
"^ni,.*":
--
2.25.0


2020-02-20 09:36:03

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

Hi Vasily

On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote:
> Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
>
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 6456a6dfd83d..a390a793422b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -665,6 +665,8 @@ patternProperties:
> description: Nexbox
> "^nextthing,.*":
> description: Next Thing Co.
> + "^neweast,.*":
> + description: Guangdong Neweast Optoelectronics CO., LT

Alphabetical order.
"new" comes before "nex".

Sam

2020-02-20 13:56:52

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

Hi Vasily,

Thank you for the patch.

On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote:
> Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
>
> Signed-off-by: Vasily Khoruzhick <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 6456a6dfd83d..a390a793422b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -665,6 +665,8 @@ patternProperties:
> description: Nexbox
> "^nextthing,.*":
> description: Next Thing Co.
> + "^neweast,.*":
> + description: Guangdong Neweast Optoelectronics CO., LT

Google only returns two hits for this name, beside the ones related to
this patch series. Are you sure this is the correct company name ?

> "^newhaven,.*":
> description: Newhaven Display International
> "^ni,.*":

--
Regards,

Laurent Pinchart

2020-02-20 21:22:09

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

Hi Laurent.

> > + "^neweast,.*":
> > + description: Guangdong Neweast Optoelectronics CO., LT
>
> Google only returns two hits for this name, beside the ones related to
> this patch series. Are you sure this is the correct company name ?

Seems legit:
http://www.eastbl.com/

But maybe their chinese name was better a basis for vendor prefix?

Guangdong New Oriental Optoelectronics

Sam

2020-02-20 21:37:23

by Vasily Khoruzhick

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

On Thu, Feb 20, 2020 at 1:21 PM Sam Ravnborg <[email protected]> wrote:
>
> Hi Laurent.
>
> > > + "^neweast,.*":
> > > + description: Guangdong Neweast Optoelectronics CO., LT
> >
> > Google only returns two hits for this name, beside the ones related to
> > this patch series. Are you sure this is the correct company name ?
>
> Seems legit:
> http://www.eastbl.com/
>
> But maybe their chinese name was better a basis for vendor prefix?
>
> Guangdong New Oriental Optoelectronics

They call themselves "Guangdong NewEast Optoelectronics" in English,
so I think it's better to keep it as is.

>
> Sam

2020-02-20 21:38:09

by Vasily Khoruzhick

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

On Thu, Feb 20, 2020 at 1:35 AM Sam Ravnborg <[email protected]> wrote:
>
> Hi Vasily
>
> On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote:
> > Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
> >
> > Signed-off-by: Vasily Khoruzhick <[email protected]>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 6456a6dfd83d..a390a793422b 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -665,6 +665,8 @@ patternProperties:
> > description: Nexbox
> > "^nextthing,.*":
> > description: Next Thing Co.
> > + "^neweast,.*":
> > + description: Guangdong Neweast Optoelectronics CO., LT
>
> Alphabetical order.
> "new" comes before "nex".

Will fix in v2

>
> Sam

2020-02-20 21:38:19

by Vasily Khoruzhick

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: Add Guangdong Neweast Optoelectronics CO. LTD vendor prefix

On Thu, Feb 20, 2020 at 5:56 AM Laurent Pinchart
<[email protected]> wrote:
>
> Hi Vasily,

Hi Laurent,

> Thank you for the patch.
>
> On Thu, Feb 20, 2020 at 12:35:05AM -0800, Vasily Khoruzhick wrote:
> > Add vendor prefix for Guangdong Neweast Optoelectronics CO. LTD
> >
> > Signed-off-by: Vasily Khoruzhick <[email protected]>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 6456a6dfd83d..a390a793422b 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -665,6 +665,8 @@ patternProperties:
> > description: Nexbox
> > "^nextthing,.*":
> > description: Next Thing Co.
> > + "^neweast,.*":
> > + description: Guangdong Neweast Optoelectronics CO., LT
>
> Google only returns two hits for this name, beside the ones related to
> this patch series. Are you sure this is the correct company name ?

That is what datasheet says:

http://files.pine64.org/doc/datasheet/pinebook/11.6inches-1080P-IPS-LCD-Panel-spec-WJFH116008A.pdf



> > "^newhaven,.*":
> > description: Newhaven Display International
> > "^ni,.*":
>
> --
> Regards,
>
> Laurent Pinchart