2020-04-07 06:53:51

by Vasily Khoruzhick

Subject: Re: [PATCH v2 3/3] arm64: allwinner: Enable Bluetooth and WiFi on sopine baseboard

On Mon, Apr 6, 2020 at 10:58 PM Alistair Francis <[email protected]> wrote:
>
> The sopine board has an optional RTL8723BS WiFi + BT module that can be
> connected to UART1. Add this to the device tree so that it will work
> for users if connected.

It's optional, so patch should have 'DO-NOT-MERGE' tag and appropriate
change should go into dt overlay.

> Signed-off-by: Alistair Francis <[email protected]>
> ---
> .../allwinner/sun50i-a64-sopine-baseboard.dts | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 2f6ea9f3f6a2..f4be1bc56b07 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -103,6 +103,16 @@ ext_rgmii_phy: ethernet-phy@1 {
> };
> };
>
> +&mmc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mmc1_pins>;
> + vmmc-supply = <&reg_dldo4>;
> + vqmmc-supply = <&reg_eldo1>;
> + non-removable;
> + bus-width = <4>;
> + status = "okay";
> +};
> +
> &mmc2 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc2_pins>;
> @@ -174,6 +184,19 @@ &uart0 {
> status = "okay";
> };
>
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> + uart-has-rtscts = <1>;
> + status = "okay";
> +
> + bluetooth {
> + compatible = "realtek,rtl8723bs-bt";
> + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
> + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> + };
> +};
> +
> /* On Pi-2 connector */
> &uart2 {
> pinctrl-names = "default";
> --
> 2.25.1
>

2020-04-08 02:43:34

by Alistair Francis

Subject: Re: [PATCH v2 3/3] arm64: allwinner: Enable Bluetooth and WiFi on sopine baseboard

On Mon, Apr 6, 2020 at 11:53 PM Vasily Khoruzhick <[email protected]> wrote:
>
> On Mon, Apr 6, 2020 at 10:58 PM Alistair Francis <[email protected]> wrote:
> >
> > The sopine board has an optional RTL8723BS WiFi + BT module that can be
> > connected to UART1. Add this to the device tree so that it will work
> > for users if connected.
>
> It's optional, so patch should have 'DO-NOT-MERGE' tag and appropriate
> change should go into dt overlay.

I was hoping to enable WiFi/Bluetooth by default, even though it's an
optional add-on for the board.

Alistair

>
> > Signed-off-by: Alistair Francis <[email protected]>
> > ---
> > .../allwinner/sun50i-a64-sopine-baseboard.dts | 23 +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > index 2f6ea9f3f6a2..f4be1bc56b07 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > @@ -103,6 +103,16 @@ ext_rgmii_phy: ethernet-phy@1 {
> > };
> > };
> >
> > +&mmc1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&mmc1_pins>;
> > + vmmc-supply = <&reg_dldo4>;
> > + vqmmc-supply = <&reg_eldo1>;
> > + non-removable;
> > + bus-width = <4>;
> > + status = "okay";
> > +};
> > +
> > &mmc2 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&mmc2_pins>;
> > @@ -174,6 +184,19 @@ &uart0 {
> > status = "okay";
> > };
> >
> > +&uart1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>;
> > + uart-has-rtscts = <1>;
> > + status = "okay";
> > +
> > + bluetooth {
> > + compatible = "realtek,rtl8723bs-bt";
> > + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
> > + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
> > + };
> > +};
> > +
> > /* On Pi-2 connector */
> > &uart2 {
> > pinctrl-names = "default";
> > --
> > 2.25.1
> >