Subject: Re: [PATCH v2 1/2] Add UFFD_USER_MODE_ONLY

On 2020-08-21 18:40:17 [-0700], Lokesh Gidra wrote:
> --- a/fs/userfaultfd.c
> +++ b/fs/userfaultfd.c
> @@ -1966,6 +1969,7 @@ static void init_once_userfaultfd_ctx(void *mem)
>
> SYSCALL_DEFINE1(userfaultfd, int, flags)
> {
> + static const int uffd_flags = UFFD_USER_MODE_ONLY;
> struct userfaultfd_ctx *ctx;
> int fd;
Why?

Sebastian


2020-08-26 00:25:30

by Lokesh Gidra

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] Add UFFD_USER_MODE_ONLY

On Mon, Aug 24, 2020 at 5:32 AM Sebastian Andrzej Siewior
<[email protected]> wrote:
>
> On 2020-08-21 18:40:17 [-0700], Lokesh Gidra wrote:
> > --- a/fs/userfaultfd.c
> > +++ b/fs/userfaultfd.c
> > @@ -1966,6 +1969,7 @@ static void init_once_userfaultfd_ctx(void *mem)
> >
> > SYSCALL_DEFINE1(userfaultfd, int, flags)
> > {
> > + static const int uffd_flags = UFFD_USER_MODE_ONLY;
> > struct userfaultfd_ctx *ctx;
> > int fd;
> Why?

Not sure! I guess Daniel didn't want to repeat the long flag name twice.

Thanks for catching that. I'll send another version fixing this.
>
> Sebastian