2023-12-04 12:09:11

by Naresh Kamboju

[permalink] [raw]
Subject: arm: gcc-8: drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element is not constant (struct group_desc)

Following build errors noticed on Linux next-20231204 tag with gcc-8 toolchain
for arm and arm64.

## Test Regressions (compared to next-20231201)
* arm, build
- gcc-8-defconfig

* arm64, build
- gcc-8-defconfig

Reported-by: Linux Kernel Functional Testing <[email protected]>

Build log arm and arm64:
------------
In file included from drivers/pinctrl/mediatek/pinctrl-moore.h:21,
from drivers/pinctrl/mediatek/pinctrl-mt7623.c:11:
drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element
is not constant
(struct group_desc) { \
^

Links:
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2Z43zPIMN6vxVKd9rKJFdOKXpox/
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231204/testrun/21472198/suite/build/test/gcc-8-defconfig/details/
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231204/testrun/21472585/suite/build/test/gcc-8-defconfig/details/
- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231204/testrun/21472800/suite/build/test/gcc-8-defconfig/history/

Steps to reproduce:
---------------
# tuxmake --runtime podman --target-arch arm64 --toolchain gcc-8
--kconfig defconfig



--
Linaro LKFT
https://lkft.linaro.org


2023-12-04 15:20:52

by Andy Shevchenko

[permalink] [raw]
Subject: Re: arm: gcc-8: drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element is not constant (struct group_desc)

On Mon, Dec 04, 2023 at 04:11:11PM +0100, Arnd Bergmann wrote:
> On Mon, Dec 4, 2023, at 13:08, Naresh Kamboju wrote:
> > Following build errors noticed on Linux next-20231204 tag with gcc-8 toolchain
> > for arm and arm64.
> >
> > ## Test Regressions (compared to next-20231201)
> > * arm, build
> > - gcc-8-defconfig
> >
> > * arm64, build
> > - gcc-8-defconfig
> >
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> >
> > Build log arm and arm64:
> > ------------
> > In file included from drivers/pinctrl/mediatek/pinctrl-moore.h:21,
> > from drivers/pinctrl/mediatek/pinctrl-mt7623.c:11:
> > drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element
> > is not constant
> > (struct group_desc) { \
>
> This apparently comes from c0c8dd0a7773 ("pinctrl: core: Add a
> convenient define PINCTRL_GROUP_DESC()") and following patches
> from Andy Shevchenko (added to Cc).
>
> I also checked different compiler versions and found that the
> new code works fine with gcc-13.2.0, but not with gcc-12 or
> older.

Thank you, Linus already dropped problematic changes.

--
With Best Regards,
Andy Shevchenko


2023-12-05 08:15:28

by Arnd Bergmann

[permalink] [raw]
Subject: Re: arm: gcc-8: drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element is not constant (struct group_desc)

On Mon, Dec 4, 2023, at 13:08, Naresh Kamboju wrote:
> Following build errors noticed on Linux next-20231204 tag with gcc-8 toolchain
> for arm and arm64.
>
> ## Test Regressions (compared to next-20231201)
> * arm, build
> - gcc-8-defconfig
>
> * arm64, build
> - gcc-8-defconfig
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> Build log arm and arm64:
> ------------
> In file included from drivers/pinctrl/mediatek/pinctrl-moore.h:21,
> from drivers/pinctrl/mediatek/pinctrl-mt7623.c:11:
> drivers/pinctrl/mediatek/../core.h:211:21: error: initializer element
> is not constant
> (struct group_desc) { \


This apparently comes from c0c8dd0a7773 ("pinctrl: core: Add a
convenient define PINCTRL_GROUP_DESC()") and following patches
from Andy Shevchenko (added to Cc).

I also checked different compiler versions and found that the
new code works fine with gcc-13.2.0, but not with gcc-12 or
older.

Arnd