2024-02-09 14:07:00

by Matthieu Baerts (NGI0)

[permalink] [raw]
Subject: Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP

Hi Maxim, Naresh,

On 09/02/2024 14:25, Maxim Galaganov wrote:
> Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> building ip_local_port_range.c, that leads to "error: use of undeclared
> identifier 'IPPROTO_MPTCP'".
>
> Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
>
> Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> Reported-by: Linux Kernel Functional Testing <[email protected]>
> Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> Signed-off-by: Maxim Galaganov <[email protected]>

Thank you both for the fix and the bug report!

Acked-by: Matthieu Baerts (NGI0) <[email protected]>

Cheers,
Matt
--
Sponsored by the NGI0 Core fund.


2024-02-12 18:39:49

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH net] selftests: net: ip_local_port_range: define IPPROTO_MPTCP

On Fri, 9 Feb 2024 at 19:27, Matthieu Baerts <[email protected]> wrote:
>
> Hi Maxim, Naresh,
>
> On 09/02/2024 14:25, Maxim Galaganov wrote:
> > Older glibc's netinet/in.h may leave IPPROTO_MPTCP undefined when
> > building ip_local_port_range.c, that leads to "error: use of undeclared
> > identifier 'IPPROTO_MPTCP'".
> >
> > Define IPPROTO_MPTCP in such cases, just like in other MPTCP selftests.
> >
> > Fixes: 122db5e3634b ("selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE")
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> > Closes: https://lore.kernel.org/netdev/CA+G9fYvGO5q4o_Td_kyQgYieXWKw6ktMa-Q0sBu6S-0y3w2aEQ@mail.gmail.com/
> > Signed-off-by: Maxim Galaganov <[email protected]>
>
> Thank you both for the fix and the bug report!
>
> Acked-by: Matthieu Baerts (NGI0) <[email protected]>

Tested-by: Linux Kernel Functional Testing <[email protected]>

--
Linaro LKFT
https://lkft.linaro.org