2022-05-12 13:07:55

by Naresh Kamboju

Subject: [next] sh: hugetlb.h:27:1: error: no return statement in function returning non-void [-Werror=return-type]

Following build regressions were noticed on sh builds on linux next-20220511
with gcc-11, gcc-10, gcc-9 and gcc-8.

Regressions found on sh:

- gcc-11-microdev_defconfig
- gcc-11-shx3_defconfig
- gcc-8-defconfig
- gcc-9-shx3_defconfig
- gcc-8-dreamcast_defconfig
- gcc-10-defconfig
- gcc-10-microdev_defconfig
- gcc-8-shx3_defconfig
- gcc-8-microdev_defconfig
- gcc-11-dreamcast_defconfig
- gcc-9-microdev_defconfig
- gcc-10-dreamcast_defconfig
- gcc-11-defconfig
- gcc-10-shx3_defconfig
- gcc-9-defconfig
- gcc-9-dreamcast_defconfig

Reported-by: Linux Kernel Functional Testing <[email protected]>

In file included from include/linux/hugetlb.h:757,
from mm/filemap.c:36:
arch/sh/include/asm/hugetlb.h: In function 'huge_ptep_clear_flush':
arch/sh/include/asm/hugetlb.h:27:1: error: no return statement in
function returning non-void [-Werror=return-type]
27 | }
| ^
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:295: mm/filemap.o] Error 1


Build url: https://builds.tuxbuild.com/291BWxg5eELaKSwUXNLIqh5w1k3/


--
Linaro LKFT
https://lkft.linaro.org

2022-05-12 18:29:45

by Matthew Wilcox

Subject: Re: [next] sh: hugetlb.h:27:1: error: no return statement in function returning non-void [-Werror=return-type]

On Wed, May 11, 2022 at 09:26:45PM +0530, Naresh Kamboju wrote:
> arch/sh/include/asm/hugetlb.h: In function 'huge_ptep_clear_flush':
> arch/sh/include/asm/hugetlb.h:27:1: error: no return statement in
> function returning non-void [-Werror=return-type]
> 27 | }
> | ^
> cc1: some warnings being treated as errors

It's easy enough to figure out whose patch this was.

$ git log -p next-20220511 arch/sh/include/asm/hugetlb.h

commit 083af99303b9
Author: Baolin Wang <[email protected]>
Date: Tue May 10 17:47:33 2022 -0700

mm: change huge_ptep_clear_flush() to return the original pte

You don't have to spray everybody who's ever touched the MM with email.

2022-05-12 23:15:13

by Baolin Wang

Subject: Re: [next] sh: hugetlb.h:27:1: error: no return statement in function returning non-void [-Werror=return-type]

Hi,

On 5/11/2022 11:56 PM, Naresh Kamboju wrote:
> Following build regressions were noticed on sh builds on linux next-20220511
> with gcc-11, gcc-10, gcc-9 and gcc-8.
>
> Regressions found on sh:
>
> - gcc-11-microdev_defconfig
> - gcc-11-shx3_defconfig
> - gcc-8-defconfig
> - gcc-9-shx3_defconfig
> - gcc-8-dreamcast_defconfig
> - gcc-10-defconfig
> - gcc-10-microdev_defconfig
> - gcc-8-shx3_defconfig
> - gcc-8-microdev_defconfig
> - gcc-11-dreamcast_defconfig
> - gcc-9-microdev_defconfig
> - gcc-10-dreamcast_defconfig
> - gcc-11-defconfig
> - gcc-10-shx3_defconfig
> - gcc-9-defconfig
> - gcc-9-dreamcast_defconfig
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> In file included from include/linux/hugetlb.h:757,
> from mm/filemap.c:36:
> arch/sh/include/asm/hugetlb.h: In function 'huge_ptep_clear_flush':
> arch/sh/include/asm/hugetlb.h:27:1: error: no return statement in
> function returning non-void [-Werror=return-type]
> 27 | }
> | ^
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:295: mm/filemap.o] Error 1
>
>
> Build url: https://builds.tuxbuild.com/291BWxg5eELaKSwUXNLIqh5w1k3/

Thanks for reporting. I'm sorry for my stupid mistakes. I've sent out a
V4 to fix building issues[1], and Stephen will update today's
(next-20220512) linux-next. Please test today's linux-next. Sorry for
troubles again.

[1]
https://lore.kernel.org/all/[email protected]/