2023-08-10 11:35:41

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-controller: add PSGMII mode


On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> Add a new PSGMII mode which is similar to QSGMII with the difference being
> that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
>
> It is commonly used by Qualcomm on their QCA807x PHY series.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



2023-08-10 11:55:04

by Robert Marko

[permalink] [raw]
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-controller: add PSGMII mode

On Thu, Aug 10, 2023 at 1:21 PM Rob Herring <[email protected]> wrote:
>
>
> On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> > Add a new PSGMII mode which is similar to QSGMII with the difference being
> > that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> >
> > It is commonly used by Qualcomm on their QCA807x PHY series.
> >
> > Signed-off-by: Robert Marko <[email protected]>
> > ---
> > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):

I am not getting any errors, nor there are any listed here as well.
Is this a bot issue maybe?

Regards
Robert
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>


--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: [email protected]
Web: http://www.sartura.hr

2023-08-10 16:56:03

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-controller: add PSGMII mode

On Thu, Aug 10, 2023 at 5:32 AM Robert Marko <[email protected]> wrote:
>
> On Thu, Aug 10, 2023 at 1:21 PM Rob Herring <[email protected]> wrote:
> >
> >
> > On Thu, 10 Aug 2023 12:22:54 +0200, Robert Marko wrote:
> > > Add a new PSGMII mode which is similar to QSGMII with the difference being
> > > that it combines 5 SGMII lines into a single link compared to 4 on QSGMII.
> > >
> > > It is commonly used by Qualcomm on their QCA807x PHY series.
> > >
> > > Signed-off-by: Robert Marko <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> >
> >
> > doc reference errors (make refcheckdocs):
>
> I am not getting any errors, nor there are any listed here as well.
> Is this a bot issue maybe?

Yes. Converting dtschema to pyproject.toml yesterday did not go well...

Rob