2015-08-12 09:00:59

by Marek Szyprowski

[permalink] [raw]
Subject: [PATCH RESEND] clk: s5pv210: add missing call to samsung_clk_of_add_provider()

Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
clk provider only after registering its all clocks", merged to v3.17-rc1)
modified a way that driver registers registers to core framework. This
change has not been applied to s5pv210 clocks driver, which has been
merged in parallel to that commit. This patch adds a missing call to
samsung_clk_of_add_provider(), so the driver is operational again.

Signed-off-by: Marek Szyprowski <[email protected]>
CC: [email protected] # v3.17+
---
drivers/clk/samsung/clk-s5pv210.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/samsung/clk-s5pv210.c b/drivers/clk/samsung/clk-s5pv210.c
index d270a20..f41b017 100644
--- a/drivers/clk/samsung/clk-s5pv210.c
+++ b/drivers/clk/samsung/clk-s5pv210.c
@@ -828,6 +828,8 @@ static void __init __s5pv210_clk_init(struct device_node *np,

s5pv210_clk_sleep_init();

+ samsung_clk_of_add_provider(np, ctx);
+
pr_info("%s clocks: mout_apll = %ld, mout_mpll = %ld\n"
"\tmout_epll = %ld, mout_vpll = %ld\n",
is_s5p6442 ? "S5P6442" : "S5PV210",
--
1.9.2


2015-08-12 09:00:24

by Tomasz Figa

[permalink] [raw]
Subject: Re: [PATCH RESEND] clk: s5pv210: add missing call to samsung_clk_of_add_provider()

2015-08-12 17:58 GMT+09:00 Marek Szyprowski <[email protected]>:
> Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
> clk provider only after registering its all clocks", merged to v3.17-rc1)
> modified a way that driver registers registers to core framework. This
> change has not been applied to s5pv210 clocks driver, which has been
> merged in parallel to that commit. This patch adds a missing call to
> samsung_clk_of_add_provider(), so the driver is operational again.
>
> Signed-off-by: Marek Szyprowski <[email protected]>
> CC: [email protected] # v3.17+
> ---
> drivers/clk/samsung/clk-s5pv210.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Acked-by: Tomasz Figa <[email protected]>

Best regards,
Tomasz

2015-08-27 22:50:33

by Michael Turquette

[permalink] [raw]
Subject: Re: [PATCH RESEND] clk: s5pv210: add missing call to samsung_clk_of_add_provider()

Quoting Tomasz Figa (2015-08-12 02:00:17)
> 2015-08-12 17:58 GMT+09:00 Marek Szyprowski <[email protected]>:
> > Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
> > clk provider only after registering its all clocks", merged to v3.17-rc1)
> > modified a way that driver registers registers to core framework. This
> > change has not been applied to s5pv210 clocks driver, which has been
> > merged in parallel to that commit. This patch adds a missing call to
> > samsung_clk_of_add_provider(), so the driver is operational again.
> >
> > Signed-off-by: Marek Szyprowski <[email protected]>
> > CC: [email protected] # v3.17+
> > ---
> > drivers/clk/samsung/clk-s5pv210.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
>
> Acked-by: Tomasz Figa <[email protected]>

The original mail slipped past my filter. Sorry about that. Also please
address all clk driver patches to [email protected] (I see that
this one is not).

I've applied to clk-next towards 4.3.

Regards,
Mike

>
> Best regards,
> Tomasz