2020-01-21 10:25:41

by Yannick FERTRE

Subject: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

From: Etienne Carriere <[email protected]>

Change DSI driver to not print an error trace when probe
is deferred for a clock resource.

Signed-off-by: Etienne Carriere <[email protected]>
---
drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
index 4b16563..2e1f266 100644
--- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
+++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
@@ -377,7 +377,9 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
dsi->pllref_clk = devm_clk_get(dev, "ref");
if (IS_ERR(dsi->pllref_clk)) {
ret = PTR_ERR(dsi->pllref_clk);
- DRM_ERROR("Unable to get pll reference clock: %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ DRM_ERROR("Unable to get pll reference clock: %d\n",
+ ret);
goto err_clk_get;
}

--
2.7.4

2020-01-23 09:55:58

by Philippe Cornu

Subject: Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

Dears Yannick & Etienne,
Thank you for your patch,

Reviewed-by: Philippe Cornu <[email protected]>

Philippe :-)

On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Etienne Carriere <[email protected]>
>
> Change DSI driver to not print an error trace when probe
> is deferred for a clock resource.
>
> Signed-off-by: Etienne Carriere <[email protected]>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 4b16563..2e1f266 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -377,7 +377,9 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
> dsi->pllref_clk = devm_clk_get(dev, "ref");
> if (IS_ERR(dsi->pllref_clk)) {
> ret = PTR_ERR(dsi->pllref_clk);
> - DRM_ERROR("Unable to get pll reference clock: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + DRM_ERROR("Unable to get pll reference clock: %d\n",
> + ret);
> goto err_clk_get;
> }
>
>

2020-02-04 11:01:00

by Benjamin Gaignard

Subject: Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

Le jeu. 23 janv. 2020 à 10:54, Philippe CORNU <[email protected]> a écrit :
>
> Dears Yannick & Etienne,
> Thank you for your patch,
>
> Reviewed-by: Philippe Cornu <[email protected]>
>
> Philippe :-)
>
> On 1/21/20 11:24 AM, Yannick Fertre wrote:
> > From: Etienne Carriere <[email protected]>
> >
> > Change DSI driver to not print an error trace when probe
> > is deferred for a clock resource.

Applied on drm-misc-next?
Thanks,
Benjamin

> >
> > Signed-off-by: Etienne Carriere <[email protected]>
> > ---
> > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> > index 4b16563..2e1f266 100644
> > --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> > +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> > @@ -377,7 +377,9 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
> > dsi->pllref_clk = devm_clk_get(dev, "ref");
> > if (IS_ERR(dsi->pllref_clk)) {
> > ret = PTR_ERR(dsi->pllref_clk);
> > - DRM_ERROR("Unable to get pll reference clock: %d\n", ret);
> > + if (ret != -EPROBE_DEFER)
> > + DRM_ERROR("Unable to get pll reference clock: %d\n",
> > + ret);
> > goto err_clk_get;
> > }
> >
> >
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel