LinuxLists.cc - [PATCH] drm/fb-cma-helpers: Fix include issue

2019-11-19 11:00:05

Subject: [PATCH] drm/fb-cma-helpers: Fix include issue

Exported functions prototypes are missing in drm_fb_cma_helper.c
Include drm_fb_cma_helper to fix that issue.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
include/drm/drm_fb_cma_helper.h | 2 ++
2 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c0b0f603af63..9801c0333eca 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -9,6 +9,7 @@
* Copyright (C) 2012 Red Hat
*/

+#include <drm/drm_fb_cma_helper.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_framebuffer.h>
#include <drm/drm_gem_cma_helper.h>
diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
index 4becb09975a4..795aea1d0a25 100644
--- a/include/drm/drm_fb_cma_helper.h
+++ b/include/drm/drm_fb_cma_helper.h
@@ -2,6 +2,8 @@
#ifndef __DRM_FB_CMA_HELPER_H__
#define __DRM_FB_CMA_HELPER_H__

+#include <linux/types.h>
+
struct drm_framebuffer;
struct drm_plane_state;

--
2.15.0

2019-12-03 16:50:51

by Benjamin Gaignard

[permalink] [raw]

Subject: Re: [PATCH] drm/fb-cma-helpers: Fix include issue

Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard
<[email protected]> a écrit :
>
> Exported functions prototypes are missing in drm_fb_cma_helper.c
> Include drm_fb_cma_helper to fix that issue.
>

Gentle ping to reviewers.
Thanks,
Benjamin

> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
> include/drm/drm_fb_cma_helper.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c0b0f603af63..9801c0333eca 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -9,6 +9,7 @@
> * Copyright (C) 2012 Red Hat
> */
>
> +#include <drm/drm_fb_cma_helper.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_framebuffer.h>
> #include <drm/drm_gem_cma_helper.h>
> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> index 4becb09975a4..795aea1d0a25 100644
> --- a/include/drm/drm_fb_cma_helper.h
> +++ b/include/drm/drm_fb_cma_helper.h
> @@ -2,6 +2,8 @@
> #ifndef __DRM_FB_CMA_HELPER_H__
> #define __DRM_FB_CMA_HELPER_H__
>
> +#include <linux/types.h>
> +
> struct drm_framebuffer;
> struct drm_plane_state;
>
> --
> 2.15.0
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2019-12-04 09:30:26

by Thomas Zimmermann

[permalink] [raw]

Subject: Re: [PATCH] drm/fb-cma-helpers: Fix include issue

Am 19.11.19 um 11:57 schrieb Benjamin Gaignard:
> Exported functions prototypes are missing in drm_fb_cma_helper.c
> Include drm_fb_cma_helper to fix that issue.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>

Acked-by: Thomas Zimmermann <[email protected]>

> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
> include/drm/drm_fb_cma_helper.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c0b0f603af63..9801c0333eca 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -9,6 +9,7 @@
> * Copyright (C) 2012 Red Hat
> */
>
> +#include <drm/drm_fb_cma_helper.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_framebuffer.h>
> #include <drm/drm_gem_cma_helper.h>
> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> index 4becb09975a4..795aea1d0a25 100644
> --- a/include/drm/drm_fb_cma_helper.h
> +++ b/include/drm/drm_fb_cma_helper.h
> @@ -2,6 +2,8 @@
> #ifndef __DRM_FB_CMA_HELPER_H__
> #define __DRM_FB_CMA_HELPER_H__
>
> +#include <linux/types.h>
> +
> struct drm_framebuffer;
> struct drm_plane_state;
>
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachments:

signature.asc (499.00 B)
OpenPGP digital signature

2020-01-09 21:00:30

by Benjamin GAIGNARD

[permalink] [raw]

Subject: Re: [PATCH] drm/fb-cma-helpers: Fix include issue

On 12/3/19 5:49 PM, Benjamin Gaignard wrote:
> Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard
> <[email protected]> a écrit :
>> Exported functions prototypes are missing in drm_fb_cma_helper.c
>> Include drm_fb_cma_helper to fix that issue.
>>
> Gentle ping to reviewers.
> Thanks,
> Benjamin

I know that removing warnings is not a sexy task, but reviewers are welcome.

Thanks,

Benjamin

>
>> Signed-off-by: Benjamin Gaignard <[email protected]>
>> ---
>> drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
>> include/drm/drm_fb_cma_helper.h | 2 ++
>> 2 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
>> index c0b0f603af63..9801c0333eca 100644
>> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
>> @@ -9,6 +9,7 @@
>> * Copyright (C) 2012 Red Hat
>> */
>>
>> +#include <drm/drm_fb_cma_helper.h>
>> #include <drm/drm_fourcc.h>
>> #include <drm/drm_framebuffer.h>
>> #include <drm/drm_gem_cma_helper.h>
>> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
>> index 4becb09975a4..795aea1d0a25 100644
>> --- a/include/drm/drm_fb_cma_helper.h
>> +++ b/include/drm/drm_fb_cma_helper.h
>> @@ -2,6 +2,8 @@
>> #ifndef __DRM_FB_CMA_HELPER_H__
>> #define __DRM_FB_CMA_HELPER_H__
>>
>> +#include <linux/types.h>
>> +
>> struct drm_framebuffer;
>> struct drm_plane_state;
>>
>> --
>> 2.15.0
>>
>> _______________________________________________
>> dri-devel mailing list
>> [email protected]
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

2020-01-09 21:00:44

by Benjamin Gaignard

[permalink] [raw]

Subject: Re: [PATCH] drm/fb-cma-helpers: Fix include issue

Le jeu. 9 janv. 2020 à 17:29, Benjamin GAIGNARD
<[email protected]> a écrit :
>
>
> On 12/3/19 5:49 PM, Benjamin Gaignard wrote:
> > Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard
> > <[email protected]> a écrit :
> >> Exported functions prototypes are missing in drm_fb_cma_helper.c
> >> Include drm_fb_cma_helper to fix that issue.
> >>
> > Gentle ping to reviewers.
> > Thanks,
> > Benjamin
>
> I know that removing warnings is not a sexy task, but reviewers are welcome.

Applied on drm-misc-next, with Thomas ack even if dri patchwork doesn't show it.

Thanks
Benjamin

>
> Thanks,
>
> Benjamin
>
> >
> >> Signed-off-by: Benjamin Gaignard <[email protected]>
> >> ---
> >> drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
> >> include/drm/drm_fb_cma_helper.h | 2 ++
> >> 2 files changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> >> index c0b0f603af63..9801c0333eca 100644
> >> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> >> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> >> @@ -9,6 +9,7 @@
> >> * Copyright (C) 2012 Red Hat
> >> */
> >>
> >> +#include <drm/drm_fb_cma_helper.h>
> >> #include <drm/drm_fourcc.h>
> >> #include <drm/drm_framebuffer.h>
> >> #include <drm/drm_gem_cma_helper.h>
> >> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> >> index 4becb09975a4..795aea1d0a25 100644
> >> --- a/include/drm/drm_fb_cma_helper.h
> >> +++ b/include/drm/drm_fb_cma_helper.h
> >> @@ -2,6 +2,8 @@
> >> #ifndef __DRM_FB_CMA_HELPER_H__
> >> #define __DRM_FB_CMA_HELPER_H__
> >>
> >> +#include <linux/types.h>
> >> +
> >> struct drm_framebuffer;
> >> struct drm_plane_state;
> >>
> >> --
> >> 2.15.0
> >>
> >> _______________________________________________
> >> dri-devel mailing list
> >> [email protected]
> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel