2021-09-14 09:17:53

by Geert Uytterhoeven

Subject: [PATCH] reset: pistachio: Re-enable driver selection

After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
longer auto-enabled when building a kernel for Pistachio systems.
Worse, the driver cannot be enabled by the user at all (unless
compile-testing), as the config symbol is invisible.

Fix this partially by making the symbol visible again when compiling for
MIPS, and dropping the useless default. The user still has to enable
the driver manually when building a kernel for Pistachio systems,
though.

Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/reset/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index be799a5abf8a6edc..b0056ae5d463aedd 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -147,8 +147,8 @@ config RESET_OXNAS
bool

config RESET_PISTACHIO
- bool "Pistachio Reset Driver" if COMPILE_TEST
- default MACH_PISTACHIO
+ bool "Pistachio Reset Driver"
+ depends on MIPS || COMPILE_TEST
help
This enables the reset driver for ImgTec Pistachio SoCs.

--
2.25.1

2021-09-14 14:47:53

by Jiaxun Yang

Subject: Re: [PATCH] reset: pistachio: Re-enable driver selection

在 2021/9/14 10:15, Geert Uytterhoeven 写道:
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default. The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Jiaxun Yang <[email protected]>

Thanks!
> ---
> drivers/reset/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
> bool
>
> config RESET_PISTACHIO
> - bool "Pistachio Reset Driver" if COMPILE_TEST
> - default MACH_PISTACHIO
> + bool "Pistachio Reset Driver"
> + depends on MIPS || COMPILE_TEST
> help
> This enables the reset driver for ImgTec Pistachio SoCs.
>

2021-09-15 05:31:42

by Rahul Bedarkar

Subject: Re: [PATCH] reset: pistachio: Re-enable driver selection

On Tue, Sep 14, 2021 at 2:46 PM Geert Uytterhoeven
<[email protected]> wrote:
>
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default. The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Rahul Bedarkar <[email protected]>

Thanks,
Rahul

> ---
> drivers/reset/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index be799a5abf8a6edc..b0056ae5d463aedd 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -147,8 +147,8 @@ config RESET_OXNAS
> bool
>
> config RESET_PISTACHIO
> - bool "Pistachio Reset Driver" if COMPILE_TEST
> - default MACH_PISTACHIO
> + bool "Pistachio Reset Driver"
> + depends on MIPS || COMPILE_TEST
> help
> This enables the reset driver for ImgTec Pistachio SoCs.
>
> --
> 2.25.1
>

2021-10-05 09:57:19

by Philipp Zabel

Subject: Re: [PATCH] reset: pistachio: Re-enable driver selection

On Tue, 2021-09-14 at 11:15 +0200, Geert Uytterhoeven wrote:
> After the retirement of MACH_PISTACHIO, the Pistachio Reset Driver is no
> longer auto-enabled when building a kernel for Pistachio systems.
> Worse, the driver cannot be enabled by the user at all (unless
> compile-testing), as the config symbol is invisible.
>
> Fix this partially by making the symbol visible again when compiling for
> MIPS, and dropping the useless default. The user still has to enable
> the driver manually when building a kernel for Pistachio systems,
> though.
>
> Fixes: 104f942b2832ab13 ("MIPS: Retire MACH_PISTACHIO")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Thank you, applied to reset/fixes.

regards
Philipp