2021-07-06 11:02:38

by Tzung-Bi Shih

[permalink] [raw]
Subject: Re: [PATCH v2,8/9] media: mtk-jpegenc: Generalize jpegenc HW operations interfaces

On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu <[email protected]> wrote:
> Generalizes jpegenc select/deselect HW and set params interfaces.
No code is using the functions. The patch needs to be submitted with
other patches.

> +static int mtk_jpeg_select_hw(struct mtk_jpeg_ctx *ctx)
> +{
> + int hw_id = -1;
> + int i;
> + unsigned long flags;
> + struct mtk_jpeg_dev *jpeg = ctx->jpeg, *comp_jpeg = NULL;
comp_jpeg doesn't need to be initialized.