2022-03-11 20:50:52

by Oliver Sang

[permalink] [raw]
Subject: [fs] 37da949345: xfstests.generic.374.fail



Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 37da9493451c35886a11bfe45d62adc27d9c46b3 ("fs: allow cross-vfsmount reflink/dedupe")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

in testcase: xfstests
version: xfstests-x86_64-1de1db8-1_20220217
with following parameters:

disk: 4HDD
fs: btrfs
test: generic-group-18
ucode: 0xec

test-description: xfstests is a regression test suite for xfs and other files ystems.
test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git


on test machine: 4 threads Intel(R) Xeon(R) CPU E3-1225 v5 @ 3.30GHz with 16G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):




If you fix the issue, kindly add following tag
Reported-by: kernel test robot <[email protected]>

2022-03-10 14:43:23 export TEST_DIR=/fs/sda1
2022-03-10 14:43:23 export TEST_DEV=/dev/sda1
2022-03-10 14:43:23 export FSTYP=btrfs
2022-03-10 14:43:23 export SCRATCH_MNT=/fs/scratch
2022-03-10 14:43:23 mkdir /fs/scratch -p
2022-03-10 14:43:23 export SCRATCH_DEV_POOL="/dev/sda2 /dev/sda3 /dev/sda4"
2022-03-10 14:43:23 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-group-18
2022-03-10 14:43:23 ./check generic/360 generic/361 generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/371 generic/372 generic/373 generic/374 generic/375 generic/376 generic/377 generic/378 generic/379
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 lkp-skl-d06 5.17.0-rc7-00085-g37da9493451c #1 SMP Thu Mar 10 21:42:40 CST 2022
MKFS_OPTIONS -- /dev/sda2
MOUNT_OPTIONS -- /dev/sda2 /fs/scratch

generic/360 1s
generic/361 12s
generic/362 [not run] this test requires richacl support on $SCRATCH_DEV
generic/363 [not run] this test requires richacl support on $SCRATCH_DEV
generic/364 [not run] this test requires richacl support on $SCRATCH_DEV
generic/365 [not run] this test requires richacl support on $SCRATCH_DEV
generic/366 [not run] this test requires richacl support on $SCRATCH_DEV
generic/367 [not run] this test requires richacl support on $SCRATCH_DEV
generic/368 [not run] this test requires richacl support on $SCRATCH_DEV
generic/369 [not run] this test requires richacl support on $SCRATCH_DEV
generic/370 [not run] this test requires richacl support on $SCRATCH_DEV
generic/371 68s
generic/372 [not run] Explicit SHARED flag reporting not support by filesystem type: btrfs
generic/373 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/373.out.bad)
--- tests/generic/373.out 2022-02-17 11:55:00.000000000 +0000
+++ /lkp/benchmarks/xfstests/results//generic/373.out.bad 2022-03-10 14:44:54.201679653 +0000
@@ -3,7 +3,6 @@
Mount otherdir
Create file
Reflink one file to another
-cp: failed to clone 'OTHER_DIR/test-373/otherfiles' from 'SCRATCH_MNT/test-373/file': Invalid cross-device link
Check output
2d61aa54b58c2e94403fb092c3dbc027 SCRATCH_MNT/test-373/file
Unmount otherdir
...
(Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/373.out /lkp/benchmarks/xfstests/results//generic/373.out.bad' to see the entire diff)
generic/374 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/374.out.bad)
--- tests/generic/374.out 2022-02-17 11:55:00.000000000 +0000
+++ /lkp/benchmarks/xfstests/results//generic/374.out.bad 2022-03-10 14:44:55.890679630 +0000
@@ -3,7 +3,8 @@
Mount otherdir
Create file
Dedupe one file to another
-XFS_IOC_FILE_EXTENT_SAME: Invalid cross-device link
+deduped 65536/65536 bytes at offset 0
+64 KiB, 1 ops; 0.0018 sec (33.967 MiB/sec and 543.4783 ops/sec)
Check output
...
(Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/374.out /lkp/benchmarks/xfstests/results//generic/374.out.bad' to see the entire diff)
generic/375 1s
generic/376 2s
generic/377 1s
generic/378 1s
generic/379 [not run] disk quotas not supported by this filesystem type: btrfs
Ran: generic/360 generic/361 generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/371 generic/372 generic/373 generic/374 generic/375 generic/376 generic/377 generic/378 generic/379
Not run: generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/372 generic/379
Failures: generic/373 generic/374
Failed 2 of 20 tests




To reproduce:

git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file

# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.



---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]

Thanks,
Oliver Sang


Attachments:
(No filename) (5.01 kB)
config-5.17.0-rc7-00085-g37da9493451c (168.17 kB)
job-script (5.66 kB)
dmesg.xz (28.10 kB)
xfstests (3.61 kB)
job.yaml (4.83 kB)
reproduce (955.00 B)
Download all attachments

2022-03-29 12:31:59

by Bruno Goncalves

[permalink] [raw]
Subject: Re: [fs] 37da949345: xfstests.generic.374.fail

On Fri, Mar 11, 2022 at 4:23 AM kernel test robot <[email protected]> wrote:
>
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 37da9493451c35886a11bfe45d62adc27d9c46b3 ("fs: allow cross-vfsmount reflink/dedupe")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
>
> in testcase: xfstests
> version: xfstests-x86_64-1de1db8-1_20220217
> with following parameters:
>
> disk: 4HDD
> fs: btrfs
> test: generic-group-18
> ucode: 0xec
>
> test-description: xfstests is a regression test suite for xfs and other files ystems.
> test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
>
>
> on test machine: 4 threads Intel(R) Xeon(R) CPU E3-1225 v5 @ 3.30GHz with 16G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
>
>
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <[email protected]>
>
> 2022-03-10 14:43:23 export TEST_DIR=/fs/sda1
> 2022-03-10 14:43:23 export TEST_DEV=/dev/sda1
> 2022-03-10 14:43:23 export FSTYP=btrfs
> 2022-03-10 14:43:23 export SCRATCH_MNT=/fs/scratch
> 2022-03-10 14:43:23 mkdir /fs/scratch -p
> 2022-03-10 14:43:23 export SCRATCH_DEV_POOL="/dev/sda2 /dev/sda3 /dev/sda4"
> 2022-03-10 14:43:23 sed "s:^:generic/:" //lkp/benchmarks/xfstests/tests/generic-group-18
> 2022-03-10 14:43:23 ./check generic/360 generic/361 generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/371 generic/372 generic/373 generic/374 generic/375 generic/376 generic/377 generic/378 generic/379
> FSTYP -- btrfs
> PLATFORM -- Linux/x86_64 lkp-skl-d06 5.17.0-rc7-00085-g37da9493451c #1 SMP Thu Mar 10 21:42:40 CST 2022
> MKFS_OPTIONS -- /dev/sda2
> MOUNT_OPTIONS -- /dev/sda2 /fs/scratch
>
> generic/360 1s
> generic/361 12s
> generic/362 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/363 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/364 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/365 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/366 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/367 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/368 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/369 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/370 [not run] this test requires richacl support on $SCRATCH_DEV
> generic/371 68s
> generic/372 [not run] Explicit SHARED flag reporting not support by filesystem type: btrfs
> generic/373 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/373.out.bad)
> --- tests/generic/373.out 2022-02-17 11:55:00.000000000 +0000
> +++ /lkp/benchmarks/xfstests/results//generic/373.out.bad 2022-03-10 14:44:54.201679653 +0000
> @@ -3,7 +3,6 @@
> Mount otherdir
> Create file
> Reflink one file to another
> -cp: failed to clone 'OTHER_DIR/test-373/otherfiles' from 'SCRATCH_MNT/test-373/file': Invalid cross-device link
> Check output
> 2d61aa54b58c2e94403fb092c3dbc027 SCRATCH_MNT/test-373/file
> Unmount otherdir
> ...
> (Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/373.out /lkp/benchmarks/xfstests/results//generic/373.out.bad' to see the entire diff)
> generic/374 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/374.out.bad)
> --- tests/generic/374.out 2022-02-17 11:55:00.000000000 +0000
> +++ /lkp/benchmarks/xfstests/results//generic/374.out.bad 2022-03-10 14:44:55.890679630 +0000
> @@ -3,7 +3,8 @@
> Mount otherdir
> Create file
> Dedupe one file to another
> -XFS_IOC_FILE_EXTENT_SAME: Invalid cross-device link
> +deduped 65536/65536 bytes at offset 0
> +64 KiB, 1 ops; 0.0018 sec (33.967 MiB/sec and 543.4783 ops/sec)
> Check output
> ...
> (Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/374.out /lkp/benchmarks/xfstests/results//generic/374.out.bad' to see the entire diff)
> generic/375 1s
> generic/376 2s
> generic/377 1s
> generic/378 1s
> generic/379 [not run] disk quotas not supported by this filesystem type: btrfs
> Ran: generic/360 generic/361 generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/371 generic/372 generic/373 generic/374 generic/375 generic/376 generic/377 generic/378 generic/379
> Not run: generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/372 generic/379
> Failures: generic/373 generic/374
> Failed 2 of 20 tests
>
>

We are also able to reproduce this on mainline kernel with gcc12, the
problem seems to have been introduced by [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5191290407668028179f2544a11ae9b57f0bcf07

Bruno
>
>
> To reproduce:
>
> git clone https://github.com/intel/lkp-tests.git
> cd lkp-tests
> sudo bin/lkp install job.yaml # job file is attached in this email
> bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
> sudo bin/lkp run generated-yaml-file
>
> # if come across any failure that blocks the test,
> # please remove ~/.lkp and /lkp dir to run from a clean state.
>
>
>
> ---
> 0-DAY CI Kernel Test Service
> https://lists.01.org/hyperkitty/list/[email protected]
>
> Thanks,
> Oliver Sang
>

2022-03-30 16:44:44

by David Sterba

[permalink] [raw]
Subject: Re: [fs] 37da949345: xfstests.generic.374.fail

On Tue, Mar 29, 2022 at 12:26:43PM +0200, Bruno Goncalves wrote:
> On Fri, Mar 11, 2022 at 4:23 AM kernel test robot <[email protected]> wrote:
> > Mount otherdir
> > Create file
> > Dedupe one file to another
> > -XFS_IOC_FILE_EXTENT_SAME: Invalid cross-device link
> > +deduped 65536/65536 bytes at offset 0
> > +64 KiB, 1 ops; 0.0018 sec (33.967 MiB/sec and 543.4783 ops/sec)
> > Check output
> > ...
> > (Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/374.out /lkp/benchmarks/xfstests/results//generic/374.out.bad' to see the entire diff)
> > generic/375 1s
> > generic/376 2s
> > generic/377 1s
> > generic/378 1s
> > generic/379 [not run] disk quotas not supported by this filesystem type: btrfs
> > Ran: generic/360 generic/361 generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/371 generic/372 generic/373 generic/374 generic/375 generic/376 generic/377 generic/378 generic/379
> > Not run: generic/362 generic/363 generic/364 generic/365 generic/366 generic/367 generic/368 generic/369 generic/370 generic/372 generic/379
> > Failures: generic/373 generic/374
> > Failed 2 of 20 tests
> >
> >
>
> We are also able to reproduce this on mainline kernel with gcc12, the
> problem seems to have been introduced by [1].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5191290407668028179f2544a11ae9b57f0bcf07

I think you need to update fstests once the patches from
https://lore.kernel.org/linux-btrfs/bad40a464e1728309e185a031e8d3652c22b68cf.1648153387.git.josef@toxicpanda.com/
are merged.