2018-11-12 19:24:07

by Diego Viola

[permalink] [raw]
Subject: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

med_power_with_dipm still causes freezes after updating the firmware to
the latest version (DXT04L5Q).

Set model_rev to NULL and blacklist the device.

Signed-off-by: Diego Viola <[email protected]>
Reviewed-by: Hans de Goede <[email protected]>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6e594644cb1d..a7f5202a4815 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4553,7 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
/* These specific Samsung models/firmware-revs do not handle LPM well */
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
{ "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
- { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
+ { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },

/* devices that don't properly handle queued TRIM commands */
{ "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
--
2.19.1



2018-11-12 19:31:33

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

On 11/12/18 12:22 PM, Diego Viola wrote:
> med_power_with_dipm still causes freezes after updating the firmware to
> the latest version (DXT04L5Q).
>
> Set model_rev to NULL and blacklist the device.

Thanks, applied.

--
Jens Axboe


2018-11-12 19:35:18

by Diego Viola

[permalink] [raw]
Subject: Re: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

On Mon, Nov 12, 2018 at 5:30 PM Jens Axboe <[email protected]> wrote:
>
> On 11/12/18 12:22 PM, Diego Viola wrote:
> > med_power_with_dipm still causes freezes after updating the firmware to
> > the latest version (DXT04L5Q).
> >
> > Set model_rev to NULL and blacklist the device.
>
> Thanks, applied.
>
> --
> Jens Axboe
>

Thanks.

2018-11-12 19:42:49

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

On Mon, Nov 12, 2018 at 05:22:52PM -0200, Diego Viola wrote:
> med_power_with_dipm still causes freezes after updating the firmware to
> the latest version (DXT04L5Q).
>
> Set model_rev to NULL and blacklist the device.
>
> Signed-off-by: Diego Viola <[email protected]>
> Reviewed-by: Hans de Goede <[email protected]>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

2018-11-12 19:44:38

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

On 11/12/18 12:42 PM, Greg KH wrote:
> On Mon, Nov 12, 2018 at 05:22:52PM -0200, Diego Viola wrote:
>> med_power_with_dipm still causes freezes after updating the firmware to
>> the latest version (DXT04L5Q).
>>
>> Set model_rev to NULL and blacklist the device.
>>
>> Signed-off-by: Diego Viola <[email protected]>
>> Reviewed-by: Hans de Goede <[email protected]>
>> ---
>> drivers/ata/libata-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Marking it stable here.

--
Jens Axboe


2018-11-12 22:22:43

by Diego Viola

[permalink] [raw]
Subject: Re: [PATCH RESEND] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

On Mon, Nov 12, 2018 at 5:42 PM Greg KH <[email protected]> wrote:
>
> On Mon, Nov 12, 2018 at 05:22:52PM -0200, Diego Viola wrote:
> > med_power_with_dipm still causes freezes after updating the firmware to
> > the latest version (DXT04L5Q).
> >
> > Set model_rev to NULL and blacklist the device.
> >
> > Signed-off-by: Diego Viola <[email protected]>
> > Reviewed-by: Hans de Goede <[email protected]>
> > ---
> > drivers/ata/libata-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>

Sorry about that, I'll get it right next time.

Thanks,
Diego