Hi All,
This patch series fixes trivial issues in RPC-IF driver.
Changes for v2:
* Balanced PM in rpcif_disable_rpm
* Fixed typo in patch 4/5
* Dropped C++ style fixes patch
* Included RB tags from Sergei
Cheers,
Prabhakar
Lad Prabhakar (5):
memory: renesas-rpc-if: Return correct value to the caller of
rpcif_manual_xfer()
memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
rpcif_{enable,disable}_rpm
memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
inline
memory: renesas-rpc-if: Export symbols as GPL
drivers/memory/renesas-rpc-if.c | 28 +++++++++-------------------
include/memory/renesas-rpc-if.h | 13 +++++++++++--
2 files changed, 20 insertions(+), 21 deletions(-)
--
2.25.1
Hi Krzysztof,
On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
<[email protected]> wrote:
>
> Hi All,
>
> This patch series fixes trivial issues in RPC-IF driver.
>
> Changes for v2:
> * Balanced PM in rpcif_disable_rpm
> * Fixed typo in patch 4/5
> * Dropped C++ style fixes patch
> * Included RB tags from Sergei
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (5):
> memory: renesas-rpc-if: Return correct value to the caller of
> rpcif_manual_xfer()
> memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> rpcif_{enable,disable}_rpm
> memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> inline
> memory: renesas-rpc-if: Export symbols as GPL
>
As these are fixes to the existing driver will these be part of v5.10 release ?
Cheers,
Prabhakar
> drivers/memory/renesas-rpc-if.c | 28 +++++++++-------------------
> include/memory/renesas-rpc-if.h | 13 +++++++++++--
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
> --
> 2.25.1
>
Hi Prabhakar,
On Thu, Dec 3, 2020 at 11:42 AM Lad, Prabhakar
<[email protected]> wrote:
> On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
> <[email protected]> wrote:
> > This patch series fixes trivial issues in RPC-IF driver.
> >
> > Changes for v2:
> > * Balanced PM in rpcif_disable_rpm
> > * Fixed typo in patch 4/5
> > * Dropped C++ style fixes patch
> > * Included RB tags from Sergei
> >
> > Cheers,
> > Prabhakar
> >
> > Lad Prabhakar (5):
> > memory: renesas-rpc-if: Return correct value to the caller of
> > rpcif_manual_xfer()
> > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> > rpcif_{enable,disable}_rpm
> > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> > inline
> > memory: renesas-rpc-if: Export symbols as GPL
> >
> As these are fixes to the existing driver will these be part of v5.10 release ?
IIUIC, only the first one[*] is a fix for an issue that could happen during
normal operation?
[*] -EPROBE_DEFER would be eaten, causing no reprobe to happen.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 03 December 2020 10:52
> To: Lad, Prabhakar <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>; Sergei Shtylyov <[email protected]>; Prabhakar
> Mahadev Lad <[email protected]>; Philipp Zabel <[email protected]>; Jiri
> Kosina <[email protected]>; Mark Brown <[email protected]>; Linux-Renesas <linux-renesas-
> [email protected]>; Pavel Machek <[email protected]>; Geert Uytterhoeven <[email protected]>; LKML
> <[email protected]>
> Subject: Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes
>
> Hi Prabhakar,
>
> On Thu, Dec 3, 2020 at 11:42 AM Lad, Prabhakar
> <[email protected]> wrote:
> > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
> > <[email protected]> wrote:
> > > This patch series fixes trivial issues in RPC-IF driver.
> > >
> > > Changes for v2:
> > > * Balanced PM in rpcif_disable_rpm
> > > * Fixed typo in patch 4/5
> > > * Dropped C++ style fixes patch
> > > * Included RB tags from Sergei
> > >
> > > Cheers,
> > > Prabhakar
> > >
> > > Lad Prabhakar (5):
> > > memory: renesas-rpc-if: Return correct value to the caller of
> > > rpcif_manual_xfer()
> > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> > > rpcif_{enable,disable}_rpm
> > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> > > inline
> > > memory: renesas-rpc-if: Export symbols as GPL
> > >
> > As these are fixes to the existing driver will these be part of v5.10 release ?
>
> IIUIC, only the first one[*] is a fix for an issue that could happen during
> normal operation?
>
Agreed (Btw I was referring to top 3 patches).
Cheers,
Prabhakar
> [*] -EPROBE_DEFER would be eaten, causing no reprobe to happen.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
On Thu, Dec 03, 2020 at 10:41:54AM +0000, Lad, Prabhakar wrote:
> Hi Krzysztof,
>
> On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
> <[email protected]> wrote:
> >
> > Hi All,
> >
> > This patch series fixes trivial issues in RPC-IF driver.
> >
> > Changes for v2:
> > * Balanced PM in rpcif_disable_rpm
> > * Fixed typo in patch 4/5
> > * Dropped C++ style fixes patch
> > * Included RB tags from Sergei
> >
> > Cheers,
> > Prabhakar
> >
> > Lad Prabhakar (5):
> > memory: renesas-rpc-if: Return correct value to the caller of
> > rpcif_manual_xfer()
> > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> > rpcif_{enable,disable}_rpm
> > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> > inline
> > memory: renesas-rpc-if: Export symbols as GPL
> >
> As these are fixes to the existing driver will these be part of v5.10 release ?
Quick look with:
git lg v5.9..v5.10-rc1 -- drivers/memory/
did not show that this driver was added in v5.10-rc1, so the fixes are
not planned to be for v5.10 release never. Why they should be? Maybe I
missed something here?
Best regards,
Krzysztof
Hi Krzysztof,
On Thu, Dec 3, 2020 at 1:19 PM Krzysztof Kozlowski <[email protected]> wrote:
>
> On Thu, Dec 03, 2020 at 10:41:54AM +0000, Lad, Prabhakar wrote:
> > Hi Krzysztof,
> >
> > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
> > <[email protected]> wrote:
> > >
> > > Hi All,
> > >
> > > This patch series fixes trivial issues in RPC-IF driver.
> > >
> > > Changes for v2:
> > > * Balanced PM in rpcif_disable_rpm
> > > * Fixed typo in patch 4/5
> > > * Dropped C++ style fixes patch
> > > * Included RB tags from Sergei
> > >
> > > Cheers,
> > > Prabhakar
> > >
> > > Lad Prabhakar (5):
> > > memory: renesas-rpc-if: Return correct value to the caller of
> > > rpcif_manual_xfer()
> > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> > > rpcif_{enable,disable}_rpm
> > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> > > inline
> > > memory: renesas-rpc-if: Export symbols as GPL
> > >
> > As these are fixes to the existing driver will these be part of v5.10 release ?
>
> Quick look with:
> git lg v5.9..v5.10-rc1 -- drivers/memory/
> did not show that this driver was added in v5.10-rc1, so the fixes are
> not planned to be for v5.10 release never. Why they should be? Maybe I
> missed something here?
>
My bad the fixes can go into v5.11.
Cheers,
Prabhakar