2015-02-04 14:55:35

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor

On Thu, Jan 15, 2015 at 5:39 PM, Lad, Prabhakar
<[email protected]> wrote:
> From: Benoit Parrot <[email protected]>
>
> this patch adds support for omnivision's ov2659
> sensor.
>
> Signed-off-by: Benoit Parrot <[email protected]>
> Signed-off-by: Lad, Prabhakar <[email protected]>
> ---

[...]

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index b1df0ad..153cd92 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -118,6 +118,7 @@ nvidia NVIDIA
> nxp NXP Semiconductors
> onnn ON Semiconductor Corp.
> opencores OpenCores.org
> +ovt OmniVision Technologies

I'm surprised there are not already compatible strings with
OmniVision. There are some examples using "omnivision", but no dts
files and examples don't count.

The stock ticker is ovti, so please use that.

Rob


2015-02-04 15:02:17

by Lad, Prabhakar

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor

Hi Rob,

Thanks for the review.

On Wed, Feb 4, 2015 at 2:55 PM, Rob Herring <[email protected]> wrote:
> On Thu, Jan 15, 2015 at 5:39 PM, Lad, Prabhakar
> <[email protected]> wrote:
>> From: Benoit Parrot <[email protected]>
>>
>> this patch adds support for omnivision's ov2659
>> sensor.
>>
>> Signed-off-by: Benoit Parrot <[email protected]>
>> Signed-off-by: Lad, Prabhakar <[email protected]>
>> ---
>
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> index b1df0ad..153cd92 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -118,6 +118,7 @@ nvidia NVIDIA
>> nxp NXP Semiconductors
>> onnn ON Semiconductor Corp.
>> opencores OpenCores.org
>> +ovt OmniVision Technologies
>
> I'm surprised there are not already compatible strings with
> OmniVision. There are some examples using "omnivision", but no dts
> files and examples don't count.
>
> The stock ticker is ovti, so please use that.
>
OK will update in the v2 version, I went with website which was ovt [1].

[1] http://www.ovt.com/

Regards,
--Prabhakar Lad

2015-02-04 15:23:19

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor

Rob,

On Wed, Feb 4, 2015 at 12:55 PM, Rob Herring <[email protected]> wrote:

> I'm surprised there are not already compatible strings with
> OmniVision. There are some examples using "omnivision", but no dts
> files and examples don't count.
>
> The stock ticker is ovti, so please use that.

That's what I sent:
http://patchwork.ozlabs.org/patch/416685/

Could you apply it?

2015-02-04 15:28:32

by Lad, Prabhakar

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor

On Wed, Feb 4, 2015 at 3:23 PM, Fabio Estevam <[email protected]> wrote:
> Rob,
>
> On Wed, Feb 4, 2015 at 12:55 PM, Rob Herring <[email protected]> wrote:
>
>> I'm surprised there are not already compatible strings with
>> OmniVision. There are some examples using "omnivision", but no dts
>> files and examples don't count.
>>
>> The stock ticker is ovti, so please use that.
>
> That's what I sent:
> http://patchwork.ozlabs.org/patch/416685/
>
Great I'll rebase the v2 on it.

Cheers,
--Prabhakar Lad

2015-02-04 16:53:20

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor

On Wed, Feb 4, 2015 at 9:23 AM, Fabio Estevam <[email protected]> wrote:
> Rob,
>
> On Wed, Feb 4, 2015 at 12:55 PM, Rob Herring <[email protected]> wrote:
>
>> I'm surprised there are not already compatible strings with
>> OmniVision. There are some examples using "omnivision", but no dts
>> files and examples don't count.
>>
>> The stock ticker is ovti, so please use that.
>
> That's what I sent:
> http://patchwork.ozlabs.org/patch/416685/
>
> Could you apply it?

Yes. Now applied.

Rob