2024-02-19 16:10:18

by Prabhakar

Subject: [PATCH 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H{P} SoC variants

From: Lad Prabhakar <[email protected]>

Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.

Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Fabrizio Castro <[email protected]>
---
.../devicetree/bindings/soc/renesas/renesas.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index c1ce4da2dc32..109fbc8d48db 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -513,6 +513,14 @@ properties:
- renesas,rzv2mevk2 # RZ/V2M Eval Board v2.0
- const: renesas,r9a09g011

+ - description: RZ/V2H{P} (R9A09G057)
+ items:
+ - enum:
+ - renesas,r9a09g057h41 # RZ/V2H
+ - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
+ - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
+ - const: renesas,r9a09g057
+
additionalProperties: true

...
--
2.34.1

2024-02-20 09:52:29

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H{P} SoC variants

On 19/02/2024 17:09, Prabhakar wrote:
> From: Lad Prabhakar <[email protected]>
>
> Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Fabrizio Castro <[email protected]>
> ---

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-02-26 13:57:47

by Prabhakar

Subject: Re: [PATCH 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H{P} SoC variants

Hi Geert,

Thank you for the review.

On Mon, Feb 26, 2024 at 1:41 PM Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Mon, Feb 19, 2024 at 5:10 PM Prabhakar <prabhakar.csengg@gmailcom> wrote:
> > From: Lad Prabhakar <[email protected]>
> >
> > Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.
>
> I think "RZ/V2H(P)" would be better, as curly braces are usually used
> to group multiple values (e.g. "RZ/G2{L,LC}").
>
Agreed, I will use "RZ/V2H(P)" (here and in rest of the other patches)

> > Signed-off-by: Lad Prabhakar <[email protected]>
> > Reviewed-by: Fabrizio Castro <[email protected]>
> > ---
> > .../devicetree/bindings/soc/renesas/renesas.yaml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > index c1ce4da2dc32..109fbc8d48db 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -513,6 +513,14 @@ properties:
> > - renesas,rzv2mevk2 # RZ/V2M Eval Board v2.0
> > - const: renesas,r9a09g011
> >
> > + - description: RZ/V2H{P} (R9A09G057)
>
> RZ/V2H(P)
>
OK.

Cheers,
Prabhakar

> > + items:
> > + - enum:
> > + - renesas,r9a09g057h41 # RZ/V2H
> > + - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
> > + - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
> > + - const: renesas,r9a09g057
> > +
> > additionalProperties: true
>
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

2024-02-26 13:58:10

by Geert Uytterhoeven

Subject: Re: [PATCH 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H{P} SoC variants

Hi Prabhakar,

Thanks for your patch!

On Mon, Feb 19, 2024 at 5:10 PM Prabhakar <[email protected]> wrote:
> From: Lad Prabhakar <[email protected]>
>
> Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.

I think "RZ/V2H(P)" would be better, as curly braces are usually used
to group multiple values (e.g. "RZ/G2{L,LC}").

> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Fabrizio Castro <[email protected]>
> ---
> .../devicetree/bindings/soc/renesas/renesas.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index c1ce4da2dc32..109fbc8d48db 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -513,6 +513,14 @@ properties:
> - renesas,rzv2mevk2 # RZ/V2M Eval Board v2.0
> - const: renesas,r9a09g011
>
> + - description: RZ/V2H{P} (R9A09G057)

RZ/V2H(P)

> + items:
> + - enum:
> + - renesas,r9a09g057h41 # RZ/V2H
> + - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
> + - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
> + - const: renesas,r9a09g057
> +
> additionalProperties: true

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds