2022-08-29 22:24:03

by Prabhakar Mahadev Lad

Subject: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property

The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU.

This patch fixes the below dtbs_check warnings:
arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected)
From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml

Signed-off-by: Lad Prabhakar <[email protected]>
---
Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 3ea94d842c33..be420a325ed3 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -77,6 +77,9 @@ properties:

clock-names: true

+ iommus:
+ maxItems: 1
+
dmas:
minItems: 4
maxItems: 4
--
2.25.1

2022-08-30 07:46:03

by Geert Uytterhoeven

Subject: Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property

Hi Prabhakar,

Thanks for your patch!

On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar
<[email protected]> wrote:
> The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU.

blocks ... SoCs

> This patch fixes the below dtbs_check warnings:
> arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected)
> From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -77,6 +77,9 @@ properties:
>
> clock-names: true
>
> + iommus:
> + maxItems: 1

I would insert iommus below dma-names, as iommus belongs to dmas,
logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as
SDHI has its own DMA controller).

> +
> dmas:
> minItems: 4
> maxItems: 4

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-08-30 08:34:04

by Lad, Prabhakar

Subject: Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property

Hi Geert,

Thank you for the review.

On Tue, Aug 30, 2022 at 8:06 AM Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar
> <[email protected]> wrote:
> > The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU.
>
> blocks ... SoCs
>
> > This patch fixes the below dtbs_check warnings:
> > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected)
> > From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -77,6 +77,9 @@ properties:
> >
> > clock-names: true
> >
> > + iommus:
> > + maxItems: 1
>
> I would insert iommus below dma-names, as iommus belongs to dmas,
> logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as
> SDHI has its own DMA controller).
>
Ok, I will move it after dmas along with an updated commit message and
send a v2.

Cheers,
Prabhakar